Closed Bug 1175067 Opened 5 years ago Closed 5 years ago

Switch Bluetooth marionette test set from BT API v1 to API v2.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
FxOS-S1 (26Jun)
Tracking Status
firefox41 --- fixed

People

(Reporter: jaliu, Assigned: jaliu)

References

Details

Attachments

(1 file, 2 obsolete files)

Bluetooth API is going to switch to API v2.
Tinderbox shouldn't run <Gecko>/dom/bluetooth/bluetooth1/tests/marionette/manifest.ini since it's designed for API v1.
Assignee: nobody → jaliu
See Also: → 1167064
Attachment #8622950 - Flags: review?(joliu)
Comment on attachment 8622950 [details] [diff] [review]
Switch Bluetooth marionette test set to BT API v2.

Review of attachment 8622950 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Jamin,

Please make sure we could pass all tests on try for v2 before checking in.
Switch to v2 test will work on tinderbox and won't affect other tests in theory, but I want to make sure nothing will be broken.
Bug 1167064 haven't landed into m-c yet, you might need to qimport those changesets when you push to try.

Thanks,
Jocelyn
Attachment #8622950 - Flags: review?(joliu) → review+
- Add reviewer's name to commit message.

Thank Jocelyn for reviewing the patch.

Treeherder:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3666a513e311
Attachment #8622950 - Attachment is obsolete: true
See Also: → 1175389
Marionette tests of bluetooth2 were designed to run at real devices.
Disable unsupported tests and create a follow-up Bug 1175389 to support BT tests on B2G emulator-kk.
Attachment #8622974 - Attachment is obsolete: true
Attachment #8623489 - Flags: review?(joliu)
Comment on attachment 8623489 [details] [diff] [review]
Switch Bluetooth marionette test set to BT API v2 and disable unsupported tests (v2)

Review of attachment 8623489 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.
Attachment #8623489 - Flags: review?(joliu) → review+
(In reply to Jocelyn Liu [:jocelyn] [:joliu] from comment #5)
> Comment on attachment 8623489 [details] [diff] [review]
> Switch Bluetooth marionette test set to BT API v2 and disable unsupported
> tests (v2)
> 
> Review of attachment 8623489 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM, thanks.

Thank Jocelyn for reviewing the patch.

Treeherder:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5cc6ece53e3
https://hg.mozilla.org/mozilla-central/rev/2c1851ceb7b0
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S1 (26Jun)
+++ b/dom/bluetooth/bluetooth2/tests/marionette/manifest.ini
@@ -1,11 +1,17 @@
 [DEFAULT]
 b2g = true
 browser = false
 qemu = false
 
+disabled = Bug 1175389
 [test_dom_BluetoothManager_API2.js]

I thought the "disabled =" stuff needs to be added after the test that you want to have disabled, no?
Flags: needinfo?(jaliu)
Flags: needinfo?(jaliu)
See Also: → 1179713
(In reply to Martijn Wargers [:mwargers] (QA) from comment #9)
> +++ b/dom/bluetooth/bluetooth2/tests/marionette/manifest.ini
> @@ -1,11 +1,17 @@
>  [DEFAULT]
>  b2g = true
>  browser = false
>  qemu = false
>  
> +disabled = Bug 1175389
>  [test_dom_BluetoothManager_API2.js]
> 
> I thought the "disabled =" stuff needs to be added after the test that you
> want to have disabled, no?

You are right.
Thank you for pointing this out.
I've filed a bug 1179713 to fix this problem.
You need to log in before you can comment on or make changes to this bug.