1175108 - Migrate test_sms_semicolon_completes_the_entered_recipient.py to Gij

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Original test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_semicolon_completes_the_entered_recipient.py

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

That's the last test to migrate from Gip. Once we have it, we can disable them in the Gip suite (bug 1175110).

There are not a lot of changes in this PR. I thought using the accessors directly in the test was a good idea (as we're moving away from the happy path), but as we have a big workaround to prevent intermittents, I preferred to add an optional argument to addNewRecipient.

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8623027 [details] [review]
Gaia PR

LGTM, just two nits and one suggestion at GitHub.

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #1)
> Created attachment 8623027 [details] [review]
> Gaia PR
> 
> That's the last test to migrate from Gip. Once we have it, we can disable
> them in the Gip suite (bug 1175110).

Yay, good job!

> There are not a lot of changes in this PR. I thought using the accessors
> directly in the test was a good idea (as we're moving away from the happy
> path), but as we have a big workaround to prevent intermittents, I preferred
> to add an optional argument to addNewRecipient.

I think it's fine.

Comment 3

[Johan Lorenzo [:jlorenzo]]

No intermittent failure related to the new tests in Gij11[1] (where the new tests are run) after 30 tries. Landed in master at: https://github.com/mozilla-b2g/gaia/commit/9ca67489806894038686ce6b9fd2e1e909ded4ac. Thanks for all the reviews, Oleg!

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=98c97aa712ea412daf1e1289b40ecf4faedee244