1175188 - |mach test| with an xpcshell test fails with --enable-application=mobile/android

Status: RESOLVED WORKSFORME

(Testing :: XPCShell Harness, defect)

Description

[Nick Alexander :nalexander [he/him]]

Is this even supposed to work?

nalexander@chocho ~/M/gecko> ./mach test toolkit/modules/tests/xpcshell/test_web_channel.js
From _tests: Kept 34320 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['test', 'toolkit/modules/tests/xpcshell/test_web_channel.js']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: run_test() takes at least 9 arguments (4 given)

  File "/Users/nalexander/Mozilla/gecko/testing/mach_commands.py", line 277, in test
    test_objects=tests, **kwargs)
  File "/Users/nalexander/Mozilla/gecko/python/mach/mach/registrar.py", line 110, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/Users/nalexander/Mozilla/gecko/python/mach/mach/registrar.py", line 85, in _run_command_handler
    result = fn(**kwargs)
  File "/Users/nalexander/Mozilla/gecko/testing/xpcshell/mach_commands.py", line 489, in run_xpcshell_test
    return xpcshell.run_test(**params)

Comment 1

[Nick Alexander :nalexander [he/him]]

nalexander@chocho ~/M/gecko> ./mach xpcshell-test toolkit/modules/tests/xpcshell/test_web_channel.js

at least tries to run something.

Comment 2

[Geoff Brown [:gbrown]]

"mach xpcshell-test" should work; see uses at https://wiki.mozilla.org/Mobile/Fennec/Android#xpcshell.

I'm not sure of the state of "mach test" wrt Android. I bet :ahal knows!

Comment 3

[Andrew Halberstadt [:ahal]]

|mach test| was built specifically with desktop in mind, I doubt it would work with android or b2g. Recently I generalized the mochitest mach command to work with android/b2g as well as desktop, but haven't done anything to |mach test| or |mach xpcshell-test|. It's doubtful I'll have much time for it in the near future either, though I agree it would be really nice to have.

Comment 4

[(not currently active) Ted Mielczarek]

`mach xpcshell-test` appears to already try to handle android/b2g:
https://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/mach_commands.py#478

so maybe we're just missing the glue between that and `mach test`?

Comment 5

[Geoff Brown [:gbrown]]

I'm not sure what was wrong here, but it works fine now.

./mach test toolkit/modules/tests/xpcshell/test_web_channel.js
using APK: /home/gbrown/objdirs/droid/dist/fennec-61.0a1.en-US.android-arm.apk
 0:01.04 adb INFO adbd running as root
 0:01.15 adb INFO su -c supported
 0:01.26 adb INFO su 0 supported
 0:01.48 adb INFO /system/bin/ls -a supported
 0:01.59 adb INFO Native cp support: True
 0:01.70 adb INFO Native chmod -R support: True
pushing /home/gbrown/objdirs/droid/_tests/xpcshell
Pushing xpcshell..
Pushing ssltunnel..
Pushing certutil..
Pushing pk12util..
Pushing BadCertServer..
Pushing OCSPStaplingServer..
Pushing GenerateOCSPResponse..
Pushing SymantecSanctionsServer..
Pushing assets/armeabi-v7a/libfreebl3.so..
Pushing assets/armeabi-v7a/liblgpllibs.so..
Pushing assets/armeabi-v7a/libmozavcodec.so..
Pushing assets/armeabi-v7a/libmozavutil.so..
Pushing assets/armeabi-v7a/libnss3.so..
Pushing assets/armeabi-v7a/libnssckbi.so..
Pushing assets/armeabi-v7a/libsoftokn3.so..
Pushing assets/armeabi-v7a/libxul.so..
Pushing lib/armeabi-v7a/libmozglue.so..
Pushing lib/armeabi-v7a/libplugin-container.so..
 0:39.89 WARNING MOZ_NODE_PATH environment variable not set. Tests requiring http/2 will fail.
 0:39.89 INFO Running tests sequentially.
 0:39.89 SUITE_START: xpcshell - running 1 tests
 0:40.52 TEST_START: toolkit/modules/tests/xpcshell/test_web_channel.js
 0:43.55 TEST_END: PASS
 0:44.60 INFO INFO | Result summary:
 0:44.60 INFO INFO | Passed: 1
 0:44.60 INFO INFO | Failed: 0
 0:44.60 INFO INFO | Todo: 0
 0:44.60 INFO INFO | Retried: 0
 0:44.60 SUITE_END
 0:44.60 
Overall Summary
===============

xpcshell
~~~~~~~~
Ran 1 checks (1 tests)
Expected results: 1
OK


mach xpcshell-test <test> works fine too.
mach test <dir> works fine too.
mach xpcshell-test <dir> works fine too.