Closed Bug 1175197 Opened 5 years ago Closed 5 years ago

Fix about:addons buttons styling

Categories

(Firefox for Android :: Add-on Manager, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: antlam, Assigned: Margaret)

Details

Attachments

(2 files)

Noticed something weird with the buttons, should be an easy cleanup? It looks kinda broken right now.

Bottom is the proposed clean up, and the top is the current. I used red dots to point to example areas where either there's weird rounding or cropping happening.

Let's see if we can just make it a consistent 3px #D7D9DB border, no rounded corners to keep things simple.
Flags: needinfo?(margaret.leibovic)
Yeah, that is weird, looks like there's a border radius or something. I'll try to make a fix.
Assignee: nobody → margaret.leibovic
Flags: needinfo?(margaret.leibovic)
Bug 1175197 - Move .buttons styles to aboutAddons.css, and set the border radius to 0. r=liuche
Attachment #8627456 - Flags: review?(liuche)
For some reason the -moz-appearance: none; rule here doesn't appear to override the border-radius style we set in content.css... maybe wesj can help us understand what's going on here when he gets back from PTO.

But in the meantime, this patch takes care of things. I also decided to move these .buttons rules to aboutReader.css, since that's the only about: page where they're used (I think we should only have actively shared styles in the shared style sheet).
Flags: needinfo?(wjohnston)
Comment on attachment 8627456 [details]
MozReview Request: Bug 1175197 - Move .buttons styles to aboutAddons.css, and set the border radius to 0. r=liuche

https://reviewboard.mozilla.org/r/12245/#review10813

Nice - I didn't actually realize that aboutApps did things differently.
Attachment #8627456 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/f2df0e5fff6c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Flags: needinfo?(wjohnston)
You need to log in before you can comment on or make changes to this bug.