1175243 - The crawling-ants scanning animation doesn't look right on devices with DPR > 1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[David Flanagan [:djf]]

The scanning animation has some kind of annoying off-by-one pixel that makes the diagonal stripes look busted. I don't know when we broke it, but it is a regression and its has been bugging me. Time to fix it.

I wonder if this could be related to devicePixelRatio !== 1

I think that Music and Video share the same animation code and we may need to fix it there, as well

Comment 1

[David Flanagan [:djf]]

I've investigated and I think this is totally a problem with devicePixelRatio. I don't think this has ever worked right on devices where dpr is not 1, so it isn't really a regression and I'm removing the flag. To make this animation work right, we need a progress.png image that is broken up into 8 distinct frames.  The original progress.png image is that way. But when it was scaled up for 1.5, 2 and 2.25 multiples, the antialiasing messed it up. I could ask visual design to fix the [e-mail] image to fix it for some devices, but I don't think that approach will work for 1.5 and 2.25 multiples: I think we need everything to work out as an integer to get that to work right.

So I think the fix will be to convert to the style of animation used is shared/style/progress_activity.css, which uses repeating-linear-gradient instead of an image.

Comment 2

[David Flanagan [:djf]]

Attachment: link to patch on github

Punam,

This is a polish patch for a long standing issue that has been bugging me. Probably not urgent to review, but when you have a chance, please take a look.

Comment 3

[Punam Dahiya [:pdahiya]]

Comment on attachment 8623860 [details] [review]
link to patch on github

Hi David

Thanks for the patch, it looks so much better now and has my r+.

Comment 4

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/1045969da9e3d325e486d4f359ae2cffebe4e812