Closed Bug 1175266 Opened 5 years ago Closed 5 years ago
_tracking UI .js fails when running locally
STR: ./mach test browser/base/content/test/general/browser_trackingUI.js Expected: It passes Actual: It fails with the following message: 25 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_trackingUI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/browser_trackingUI.js:76 - TypeError: PopupNotifications.panel.firstChild.disableTrackingContentProtection is not a function Stack trace: testTrackingPage@chrome://mochitests/content/browser/browser/base/content/test/general/browser_trackingUI.js:76:3 @chrome://mochitests/content/browser/browser/base/content/test/general/browser_trackingUI.js:130:1 Tester_execTest@chrome://mochikit/content/browser-test.js:741:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:664:7 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:746:59 Tester_execTest@chrome://mochikit/content/browser-test.js:741:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:664:7 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:746:59 SUITE-END | took 6s This should pass locally so we can make changes to the feature / test.
Needed to wait for the binding to be attached after showing the popup before proceeding in the test. Not sure why it was only triggered locally, seems like a timing issue.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8623271 - Flags: review?(MattN+bmo)
Attachment #8623271 - Flags: review?(MattN+bmo) → review+
Just added a minor change I discussed with Matt - switched: isnot(PopupNotifications.panel.firstChild.isTrackingContentBlocked, 0) to is(PopupNotifications.panel.firstChild.isTrackingContentBlocked, Ci.nsIWebProgressListener.STATE_BLOCKED_TRACKING_CONTENT) which is actually a better assertion - this was passing locally even when the binding wasn't added and it should have been failing, since isTrackingContentBlocked was undefined which !== 0.
Whiteboard: [fxprivacy] → [fixed-in-fx-team][fxprivacy]
Hi Brian, should this bug be marked as qe‑verify '+' or '-' for verification?
qe- since it's a test-only change.
You need to log in before you can comment on or make changes to this bug.