1175289 - 18012 instances of 'WARNING: Subdocument container has no frame' while running linux64 debug tests

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Eric Rahm [:erahm]]

There are 18012 instances of 'WARNING: Subdocument container has no frame: file layout/base/nsDocumentViewer.cpp, line 2520' emitted when running linux64 debug log tests. These are spread out somewhate evenly across tests. We have bug 519407 on file to investigate further, for now lets go ahead and silence the warnings by default.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Part 1: Add LAYOUT_WARNING

This adds an analog to NS_WARNING for using with the layout log. When layout logging is enabled the output format looks like:
> 1980789504[10039d070]: [42963] WARNING: Subdocument container has no frame: file /Users/ericrahm/dev/mozilla-central/layout/base/nsDocumentViewer.cpp, line 2521

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 2: Disable "Subdocument container has no frame" warning by default

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8623287 [details] [diff] [review]
Part 1: Add LAYOUT_WARNING

You forgot the bug number in the commit message.

Comment 4

[Eric Rahm [:erahm]]

(In reply to Mats Palmgren (:mats) from comment #3)
> Comment on attachment 8623287 [details] [diff] [review]
> Part 1: Add LAYOUT_WARNING
> 
> You forgot the bug number in the commit message.

Interesting, must be a quirk of bzexport. Luckily, it's updated locally!

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 8623291 [details] [diff] [review]
Part 2: Disable "Subdocument container has no frame" warning by default

Might be worth adding "// XXX bug 1175289" at the end there to point out
why this warning is disabled?

Comment 6

[Eric Rahm [:erahm]]

(In reply to Mats Palmgren (:mats) from comment #5)
> Comment on attachment 8623291 [details] [diff] [review]
> Part 2: Disable "Subdocument container has no frame" warning by default
> 
> Might be worth adding "// XXX bug 1175289" at the end there to point out
> why this warning is disabled?

Good idea, I'll add the note.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ef44a112b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/31303df54182

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5ef44a112b5
https://hg.mozilla.org/mozilla-central/rev/31303df54182