Closed Bug 1175353 Opened 9 years ago Closed 9 years ago

[Settings] Convert sound switch to use gaia-switch

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file, 1 obsolete file)

[Pull Request] Convert sound panel switch to use gaia-switch
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
In preparation for moving to building blocks.
Comment on attachment 8623385 [details] [review]
[Pull Request] Convert sound panel switch to use gaia-switch

Arthur - would you happen to be able to put a review stamp on this easy one? Thank you!
Attachment #8623385 - Flags: review?(arthur.chen)
Comment on attachment 8623385 [details] [review]
[Pull Request] Convert sound panel switch to use gaia-switch

r=me, thanks!
Attachment #8623385 - Flags: review?(arthur.chen) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/dac3e6f4e7b7883c34244fb57265e67931877c4b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
sorry had to revert this for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2188538&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(kgrandon)
Resolution: FIXED → ---
New pull request with test fixes, not sure why this didn't fail on gaia-try before, but I was able to repro it locally. Carrying review.
Attachment #8623385 - Attachment is obsolete: true
Flags: needinfo?(kgrandon)
Attachment #8624554 - Flags: review+
Flags: needinfo?(kgrandon)
Try looks pretty green since the test update, let's land this again: https://github.com/mozilla-b2g/gaia/commit/ebe8099162234338dd95f8343651393b9de62dba
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: