Closed
Bug 1175383
Opened 11 years ago
Closed 11 years ago
[e10s] TabChild should store PuppetWidget directly instead of nsIWidget
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
21.27 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
TabChild is now creates PuppetWidget itself and stores it as a pointer to nsIWidget. Some code in it uses static_cast<PuppetWidget*>(mWidget.get()). This is redundant and looks like that not safe.
We should guarantee the widget is PuppetWidget.
|
Assignee | |
Updated•11 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
|
|
Assignee | |
Comment 1•11 years ago
|
||
I'm not sure if you're a good person to review this, though. Could you review this?
Attachment #8623522 -
Flags: review?(bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8623522 [details] [diff] [review]
Patch
The static_casts are safe, but this is good anyhow.
Could you file a followup for the nsContentUtils::SendKeyEvent issue.
Attachment #8623522 -
Flags: review?(bugs) → review+
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•