Closed Bug 1175388 Opened 6 years ago Closed 6 years ago

[Linter: AlwaysShowAction] Disable android-lint rule at a file level

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

via lint:

Using showAsAction="always" in menu XML, or MenuItem.SHOW_AS_ACTION_ALWAYS in Java code is usually a deviation from the user interface style guide.Use ifRoom or the corresponding MenuItem.SHOW_AS_ACTION_IF_ROOM instead.

If always is used sparingly there are usually no problems and behavior is roughly equivalent to ifRoom but with preference over other ifRoom items. Using it more than twice in the same menu is a bad idea.

This check looks for menu XML files that contain more than two always actions, or some always actions and no ifRoom actions. In Java code, it looks for projects that contain references to MenuItem.SHOW_AS_ACTION_ALWAYS and no references to MenuItem.SHOW_AS_ACTION_IF_ROOM. 

---

We actually override how the menu system works and so this warning is not relevant to us.
Bug 1175388 - Disable AlwaysShowAction on a file level. r=margaret

We have a custom menu system here and interpret these attributes ourselves so
this warning isn't relevant to us.
Attachment #8623454 - Flags: review?(margaret.leibovic)
Assignee: nobody → michael.l.comella
Summary: [Linter: AlwaysShowAction] Disable android-lint rule → [Linter: AlwaysShowAction] Disable android-lint rule at a file level
Comment on attachment 8623454 [details]
MozReview Request: Bug 1175388 - Disable AlwaysShowAction on a file level. r=margaret

https://reviewboard.mozilla.org/r/11551/#review10177

Ship It!
Attachment #8623454 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/8a3519734f64
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.