1175388 - [Linter: AlwaysShowAction] Disable android-lint rule at a file level

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via lint:

Using showAsAction="always" in menu XML, or MenuItem.SHOW_AS_ACTION_ALWAYS in Java code is usually a deviation from the user interface style guide.Use ifRoom or the corresponding MenuItem.SHOW_AS_ACTION_IF_ROOM instead.

If always is used sparingly there are usually no problems and behavior is roughly equivalent to ifRoom but with preference over other ifRoom items. Using it more than twice in the same menu is a bad idea.

This check looks for menu XML files that contain more than two always actions, or some always actions and no ifRoom actions. In Java code, it looks for projects that contain references to MenuItem.SHOW_AS_ACTION_ALWAYS and no references to MenuItem.SHOW_AS_ACTION_IF_ROOM. 

---

We actually override how the menu system works and so this warning is not relevant to us.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1175388 - Disable AlwaysShowAction on a file level. r=margaret

Bug 1175388 - Disable AlwaysShowAction on a file level. r=margaret

We have a custom menu system here and interpret these attributes ourselves so
this warning isn't relevant to us.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8623454 [details]
MozReview Request: Bug 1175388 - Disable AlwaysShowAction on a file level. r=margaret

https://reviewboard.mozilla.org/r/11551/#review10177

Ship It!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/8a3519734f64

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a3519734f64