Bug 1174625 tweaked the API of PLDHashTable's iterator.
The changes within TokenEnumeration are simple. The changes in observeMessage() are a little more complex. PLDHashTable::Iterator no longer has a copy constructor, so instead of creating a long-lived TokenEnumeration at the start and then passing a copy to each call to forgetToken() and rememberToken(), instead we pass the Tokenizer and create from it a new short-lived TokenEnumeration within forgetToken() and rememberToken(). IMO the new code is easier to understand because the TokenEnumerations are shorter-lived. I've checked the new code compiles, but I haven't tested it in any way.
Attachment #8623531 - Flags: review?(rkent)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8623531 [details] [diff] [review] Update comm-central for PLDHashTable changes in bug 117462 Looks good to me. Thanks for fixing comm-central!
Attachment #8623531 - Flags: review?(rkent) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.