1175442 - nsContentUtils::SendKeyEvent() should take nsIWidget* rather than nsCOMPtr<nsIWidget> at its first argument

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsContentUtils::SendKeyEvent() is defined as:

> 2360   static nsresult SendKeyEvent(nsCOMPtr<nsIWidget> aWidget,
> 2361                                const nsAString& aType,
> 2362                                int32_t aKeyCode,
> 2363                                int32_t aCharCode,
> 2364                                int32_t aModifiers,
> 2365                                uint32_t aAdditionalFlags,
> 2366                                bool* aDefaultActionTaken);

However, this means that the caller needs to create a local variable of nsCOMPtr<nsIWidget> if the caller has a pointer to an nsIWidget derived class. So, it should be nsIWidget* for allowing to accept all nsIWidget derived classes.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/328551ccf9ee

Comment 3

[[e-mail]]

Out of interest, what about SendMouseEvent?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to [e-mail] from comment #3)
> Out of interest, what about SendMouseEvent?

I'm not sure. It takes nsCOMPtr<nsIPresShell>, but its concrete class is only PresShell and I don't see such code which holds with nsRefPtr. But if some callers making nsCOMPtr<nsIPresShell> from raw pointer (nsIPresShell*), we should do that too.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/328551ccf9ee