nsContentUtils::SendKeyEvent() is defined as: > 2360 static nsresult SendKeyEvent(nsCOMPtr<nsIWidget> aWidget, > 2361 const nsAString& aType, > 2362 int32_t aKeyCode, > 2363 int32_t aCharCode, > 2364 int32_t aModifiers, > 2365 uint32_t aAdditionalFlags, > 2366 bool* aDefaultActionTaken); However, this means that the caller needs to create a local variable of nsCOMPtr<nsIWidget> if the caller has a pointer to an nsIWidget derived class. So, it should be nsIWidget* for allowing to accept all nsIWidget derived classes.
Created attachment 8623627 [details] [diff] [review] Patch
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #8623627 - Flags: review?(bugs)
3 years ago
Attachment #8623627 - Flags: review?(bugs) → review+
3 years ago
Out of interest, what about SendMouseEvent?
(In reply to firstname.lastname@example.org from comment #3) > Out of interest, what about SendMouseEvent? I'm not sure. It takes nsCOMPtr<nsIPresShell>, but its concrete class is only PresShell and I don't see such code which holds with nsRefPtr. But if some callers making nsCOMPtr<nsIPresShell> from raw pointer (nsIPresShell*), we should do that too.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.