1175453 - [App Grouping]Collapsing/Expanding is too slow

Status: RESOLVED DUPLICATE of bug 1077169

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

Compared to v2.2, the performance of app grouping at master branch is slow.
Collapsing/Expanding a group takes near 1s longer than 2.2 at both normal & edit mode.


*Test Env:
Build ID               20150616160206
Gaia Revision          9d42e94446f2dc01b519172b6d75d81d4d435bdc
Gaia Date              2015-06-16 16:16:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/27caa5299f9f
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150616.194325
Firmware Date          Tue Jun 16 19:43:36 EDT 2015
Bootloader             L1TC000118D0

Comment 1

[Hermes Cheng (inactive after July 27, 2015)]

[Blocking Requested - why for this release]:

Comment 2

[Chris Lord [:cwiiis]]

If this is fine in 2.2, let's get a regression window.

Comment 3

[Clément Lefèvre]

I will add that on master, the time is greatly increasing depending on how many icons are present on the homescreen: it's way faster after a fresh flash and no apps than with the restored profile and a couple of apps icons presents.

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to Clément Lefèvre from comment #3)
> I will add that on master, the time is greatly increasing depending on how
> many icons are present on the homescreen: it's way faster after a fresh
> flash and no apps than with the restored profile and a couple of apps icons
> presents.

Yes, but I am not sure if this is the same issue. At this bug, both 2.2 and master device I tested were with fresh builds. Even only 3 icons, the master build is also slower.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

We generally don't do windows for perf regressions because they are rarely accurate and usually caused by an accumulation of changes across the phone instead of a single change.

Comment 6

[Bobby Chien]

[Tracking Requested - why for this release]:

Comment 7

[Bobby Chien]

Attachment: homescreen_reflow.json

Comment 8

[Bobby Chien]

Attachment: App_Grouping_Collapsing_Expanding_perf.png

Comment 9

[Bobby Chien]

Observations per comment 7 and comment 8:
1. too much recalculation and reflow during collapse/expand.
2. more icons will cause more latency