Closed Bug 1175462 Opened 9 years ago Closed 9 years ago

Automatic MUC rejoins don't always work

Categories

(Chat Core :: XMPP, defect)

Product:
Chat Core
Component:
XMPP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38? affected, thunderbird_esr3839+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
thunderbird38 ? affected
thunderbird_esr38 39+ fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Keywords: regression)

Attachments

(1 file)

mucrejoinfix.diff
1.14 KB, patch
clokep
: review+
rkent
: approval-comm-esr38+
Details | Diff | Splinter Review 
STR 
Join jdev@conference.jabber.org
Go offline and then back online
The room does not get rejoined automatically.

Automatic rejoins seem to work for rooms on the user's server, however. Needs some investigating...
Ouch, this turns out to be a missed variable rename that means this has been broken for a long time.

It didn't get noticed because for autojoined channels, bug 1059289 hides the issue.

We should uplift to TB38.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8623605 - Flags: review?(clokep)
Regression caused by bug 1018771.
Blocks: 1018771
Keywords: regression
Attachment #8623605 - Flags: review?(clokep) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Comment on attachment 8623605 [details] [diff] [review]
mucrejoinfix.diff

[Approval Request Comment]
Regression caused by (bug #): 1018771 
Risk to taking this patch (and alternatives if risky): low (single line typo fix)
Attachment #8623605 - Flags: approval-comm-esr38?
Comment on attachment 8623605 [details] [diff] [review]
mucrejoinfix.diff

http://hg.mozilla.org/releases/comm-esr38/rev/01e25df7d11a
Attachment #8623605 - Flags: approval-comm-esr38? → approval-comm-esr38+
It looks like this went to a TB38 branch. Rkent, does the tracking-thunderbird38 flag need to be set/cleared?
I'm pretty much ignoring the tracking-thunderbird38 flag at this point in favor of tracking-thunderbird_esr38 which is set correctly.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: