Closed Bug 1175563 Opened 5 years ago Closed 5 years ago

Change LinearLayout to a less expensive View for doorhanger_overlay

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: sergej, Mentored)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

As Martyn pointed out in [1], the View here doesn't have anything added to it and can probably be a simpler ViewGroup (or even View, imo!).

[1]:  https://bugzilla.mozilla.org/show_bug.cgi?id=1170884#c29
To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
Attachment #8625834 - Flags: review?(michael.l.comella)
Comment on attachment 8625834 [details] [diff] [review]
Change LinearLayout to basic View

Review of attachment 8625834 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks again! lgtm! try below.
Attachment #8625834 - Flags: review?(michael.l.comella) → review+
Assignee: nobody → sergej
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b8503f1aef66
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.