1175574 - Add a Today widget for "Go to copied link"

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

Chrome has an "Open from clipboard" thing in the today pane which is useful if you want to open something from your email or twitter.

Comment 1

[Robin Andersen [:tecgirl]]

Attachment: Notification - Today + Clipboard - SC.png

Comment 2

[Robin Andersen [:tecgirl]]

Attachment: Notification - Today + Clipboard - Highlight.png

Comment 3

[Robin Andersen [:tecgirl]]

Attachment: todayCopiedLink.zip

Comment 4

[Robin Andersen [:tecgirl]]

Highlight state: the entire cell with R216 G216 B216 A44

Comment 5

[Robin Andersen [:tecgirl]]

This should not be its own widget, but part of https://bugzilla.mozilla.org/show_bug.cgi?id=1250946

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Added localizable string.
Added icons, but not using them yet.

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Attachment: Open copied link, no icon or link.

Comment 8

[Robin Andersen [:tecgirl]]

Comment on attachment 8740412 [details]
Open copied link, no icon or link.

Note the grey bg is only on press.

Comment 9

[James Hugman [:jhugman] [@jhugman]]

Attachment: Copy link button not visible on the lock screen

Comment 10

[James Hugman [:jhugman] [@jhugman]]

Attachment: Copy link visible when there is a URL on the clipboard

Comment 11

[James Hugman [:jhugman] [@jhugman]]

Attachment: Copy link button not visible if there is non-link on the clipboard

Comment 12

[Emily Toop (:fluffyemily)]

Comment on attachment 8740153 [details] [review]
Pull request

Just a few minor nits and tings

Comment 13

[James Hugman [:jhugman] [@jhugman]]

Squashed and merged. 

Needs uplift for 4.0

Comment 14

[James Hugman [:jhugman] [@jhugman]]

Resolved.

Comment 15

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8740153 [details] [review]
Pull request

LGTM. Small nit about the magic error code 257.

Comment 16

[Stephan Leroux [:sleroux]]

v4.x b8b7950

Comment 17

[Aaron Train [:aaronmt]]

Noting via testing that clipboard URL's acquired via private tabs can be visible