1175584 - Backout not being parsed from b4060e527bd2

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4060e527bd2 backs out https://hg.mozilla.org/integration/mozilla-inbound/rev/b8601df335c1. For whatever reason, the parser isn't picking up the backout syntax from b4060e527bd2. That likely explains why b8601df335c1 isn't listing a backout.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozautomation: detect "backout XXX" syntax (bug 1175584); r?smacleod

mozautomation: detect "backout XXX" syntax (bug 1175584); r?smacleod

We weren't detecting the "backout <changeset>" syntax in commit messages
as backouts of single commits. This syntax is not the official syntax
used by the backout extension. But it occurs enough that it is worth
parsing for.

Comment 2

[(Away)]

As long as you're in the file... maybe "back out" as well?

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8623764 [details]
MozReview Request: mozautomation: detect "backout XXX" syntax (bug 1175584); r?smacleod

mozautomation: detect "backout XXX" syntax (bug 1175584); r?smacleod

We weren't detecting the "backout <changeset>" syntax in commit messages
as backouts of single commits. This syntax is not the official syntax
used by the backout extension. But it occurs enough that it is worth
parsing for.

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8623764 [details]
MozReview Request: mozautomation: detect "backout XXX" syntax (bug 1175584); r?smacleod

https://reviewboard.mozilla.org/r/11587/#review10017

LGTM

::: pylib/mozautomation/mozautomation/commitparser.py:36
(Diff revision 2)
> +BACKOUT_RE = re.compile('^back\s?out (?P<node>[0-9a-f]{12}) ', re.I)

Maybe we should get "Backs out ..." as well?

Comment 5

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/11587/#review10019

> Maybe we should get "Backs out ..." as well?

``hg log -k 'backs out'`` says this syntax isn't used. So not worth it.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/48da04d37b71

Comment 7

[Gregory Szorc [:gps]]

This is deployed. https://hg.mozilla.org/integration/mozilla-inbound/rev/b8601df335c1 now displays