[Raptor] Cannot run reference workload script against bitbar devices

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
All the bitbar-based Raptor jobs fail to run when they are configured to use the reference workloads, e.g. `make reference-workload-light`. This is because they try to use adb directly instead of passing in host connection information.
(Assignee)

Comment 1

4 years ago
Created attachment 8623887 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30636

Could either of you two review this?
Attachment #8623887 - Flags: review?(jhylands)
Attachment #8623887 - Flags: review?(dave.hunt)
Comment on attachment 8623887 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30636

It looks reasonable to me, but I haven't tested it myself (not set up for that at this moment). Eli, I assume you tested this on non-bitbar phones and it still works...
Attachment #8623887 - Flags: review?(jhylands) → review+
(Assignee)

Comment 3

4 years ago
Yes, I ran this locally against my Flame and it still operated as normal without any other ADB provided. Thanks!
(Assignee)

Comment 4

4 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/236a9f6adab172942d5c4dd6ec3427d1b9d83d15

Keeping this bug open until I can verify it as fixed on Jenkins.
Attachment #8623887 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 8624382 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30659

Need to propagate the introduced adb environment command into the sub-scripts.
Attachment #8624382 - Flags: review?(jhylands)
Comment on attachment 8624382 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30659

Good catch.
Attachment #8624382 - Flags: review?(jhylands) → review+
(Assignee)

Comment 7

4 years ago
Reference workloads are now working correctly against bitbar devices. I can die happy now. \o/
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.