1175688 - [Raptor] Cannot run reference workload script against bitbar devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

All the bitbar-based Raptor jobs fail to run when they are configured to use the reference workloads, e.g. `make reference-workload-light`. This is because they try to use adb directly instead of passing in host connection information.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30636

Could either of you two review this?

Comment 2

[Jon Hylands [:jhylands]]

Comment on attachment 8623887 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30636

It looks reasonable to me, but I haven't tested it myself (not set up for that at this moment). Eli, I assume you tested this on non-bitbar phones and it still works...

Comment 3

[:Eli Perelman]

Yes, I ran this locally against my Flame and it still operated as normal without any other ADB provided. Thanks!

Comment 4

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/gaia/commit/236a9f6adab172942d5c4dd6ec3427d1b9d83d15

Keeping this bug open until I can verify it as fixed on Jenkins.

Comment 5

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30659

Need to propagate the introduced adb environment command into the sub-scripts.

Comment 6

[Jon Hylands [:jhylands]]

Comment on attachment 8624382 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30659

Good catch.

Comment 7

[:Eli Perelman]

Reference workloads are now working correctly against bitbar devices. I can die happy now. \o/