1175752 - TestMP4Reader.cpp started failing since it last ran on integration branches

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

A regression I noticed means we haven't been running check tests for about 2 weeks. The try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8589ff914781 reveals test failures in TestMP4Reader.cpp.

Disabling or fixing this test will block turning check tests back on.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

NI? bholley as author of a change to MP4Reader.cpp in the impacted range, please redirect as appropriate.

Comment 2

[Jean-Yves Avenard [:jya]]

I have the feeling that it's bug 1168040 that introduce the problem. Well, it actually solved the problem but this test checked on the wrong values.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

I'm planning to disable this test temporarily so we can get the rest of make check turned back on.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #3)
> I'm planning to disable this test temporarily so we can get the rest of make
> check turned back on.

https://hg.mozilla.org/mozilla-central/rev/cdb870a85553 will need to be reverted to re-enable this whenever it's fixed.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Jean-Yves - is there any work to be done here?

Comment 6

[Ralph Giles (:rillian)]

I filed bug 1363500 to remove the disabled test. The underlying implementation is gone.