TestMP4Reader.cpp started failing since it last ran on integration branches

RESOLVED WORKSFORME

Status

()

defect
RESOLVED WORKSFORME
4 years ago
2 years ago

People

(Reporter: chmanchester, Assigned: jya)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

A regression I noticed means we haven't been running check tests for about 2 weeks. The try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8589ff914781 reveals test failures in TestMP4Reader.cpp.

Disabling or fixing this test will block turning check tests back on.
NI? bholley as author of a change to MP4Reader.cpp in the impacted range, please redirect as appropriate.
Flags: needinfo?(bobbyholley)
I have the feeling that it's bug 1168040 that introduce the problem. Well, it actually solved the problem but this test checked on the wrong values.
Flags: needinfo?(bobbyholley)
Assignee: nobody → jyavenard
I'm planning to disable this test temporarily so we can get the rest of make check turned back on.
(In reply to Chris Manchester [:chmanchester] from comment #3)
> I'm planning to disable this test temporarily so we can get the rest of make
> check turned back on.

https://hg.mozilla.org/mozilla-central/rev/cdb870a85553 will need to be reverted to re-enable this whenever it's fixed.
Component: Audio/Video → Audio/Video: Playback
Jean-Yves - is there any work to be done here?
Flags: needinfo?(jyavenard)
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jyavenard)
Resolution: --- → WORKSFORME
I filed bug 1363500 to remove the disabled test. The underlying implementation is gone.
You need to log in before you can comment on or make changes to this bug.