Closed
Bug 1175756
Opened 9 years ago
Closed 8 years ago
Change JIT Optimizations to be a view option rather than a recording feature
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 affected, firefox47 fixed)
RESOLVED
FIXED
Firefox 47
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
26.03 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
With bug 1175705, this has optimizations as a per-recording basis, like the other settings which optionally record memory, allocations, framerate, etc, rather than a visual toggle. This lets us not do extra work on the client to assemble optimization data, and an opportunity to not send opt data over the wire. Is this an option we can add to the profiler? This does mean previous recordings with opt data will not be shown unless the recording was marked with having opt data.
Assignee | ||
Updated•9 years ago
|
Summary: Do not record/send optimization data unless requested → Change JIT Optimizations to be a view option rather than a recording feature
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11330b93e1e7
Attachment #8715530 -
Flags: review?(vporof)
Updated•8 years ago
|
Attachment #8715530 -
Flags: review?(vporof) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07f9be6ddc8d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 5•8 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #4) > https://hg.mozilla.org/mozilla-central/rev/07f9be6ddc8d > -<!ENTITY performanceUI.enableJITOptimizations.tooltiptext "Record JIT optimization data sampled in each JavaScript frame."> > +<!ENTITY performanceUI.showJITOptimizations.tooltiptext "Show JIT optimization data sampled in each JavaScript frame."> Please do not use trailing periods in tooltips unless 2 or more lines are involved, as mentioned in other Devtools bugs. Tooltips should never end with a period in order to avoid implying use of imperative mood (=instruction to user), which is valid for English as well as for localizers who keep running into this issue and wonder what verbs to use, especially in Devtools files. It would be nice to see them all cleared "when at it" (when someone is working on a Devtools file), and someone doing QA watching for this. See https://bugzilla.mozilla.org/show_bug.cgi?id=1163763#c39.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•