1175757 - Remove pyinotify dependency since the celery autoreload feature is broken anyway

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

We have pyinotify in dev.txt to support autoreloading in Celery, but don't actually use it / refer to it in the docs.

We should either remove pyinotify from dev.txt or start using/documenting it.

http://celery.readthedocs.org/en/latest/userguide/workers.html#autoreloading

Comment 1

[Ed Morley [:emorley]]

Cameron/Will/James, do any of you use --autoreload currently? Should we add it (conditional on being run from the local development environment) to the bin scripts, or just remove the otherwise unused pyinotify package from requirements/dev.txt?

Comment 2

[Ed Morley [:emorley]]

Though that said, it seems like the feature is broken at the moment:
https://github.com/celery/celery/issues/1658
https://github.com/celery/celery/issues/1025
https://github.com/celery/celery/issues/1880

Perhaps we should just remove pyinotify at the moment.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:rm-pyinotify > mozilla:master

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8750685 [details] [review]
[treeherder] mozilla:rm-pyinotify > mozilla:master

Nope, I never tried to use that feature anyway.  :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/34b107fe118781a68dd1c871d4da0f003f1d24a8
Bug 1175757 - Remove unused pyinotify dependency from dev.txt

Since the celery auto-reload feature which it enables hasn't been
working for some time regardless:
https://github.com/celery/celery/issues/1658
https://github.com/celery/celery/issues/1025
https://github.com/celery/celery/issues/1880