Closed
Bug 1175757
Opened 9 years ago
Closed 9 years ago
Remove pyinotify dependency since the celery autoreload feature is broken anyway
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
We have pyinotify in dev.txt to support autoreloading in Celery, but don't actually use it / refer to it in the docs.
We should either remove pyinotify from dev.txt or start using/documenting it.
http://celery.readthedocs.org/en/latest/userguide/workers.html#autoreloading
Assignee | ||
Comment 1•9 years ago
|
||
Cameron/Will/James, do any of you use --autoreload currently? Should we add it (conditional on being run from the local development environment) to the bin scripts, or just remove the otherwise unused pyinotify package from requirements/dev.txt?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → emorley
Assignee | ||
Comment 2•9 years ago
|
||
Though that said, it seems like the feature is broken at the moment:
https://github.com/celery/celery/issues/1658
https://github.com/celery/celery/issues/1025
https://github.com/celery/celery/issues/1880
Perhaps we should just remove pyinotify at the moment.
Assignee | ||
Updated•9 years ago
|
Summary: Use --autoreload with Celery in Vagrant → Remove pyinotify dependency since the celery autoreload feature is broken anyway
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8750685 -
Flags: review?(cdawson)
Comment 4•9 years ago
|
||
Comment on attachment 8750685 [details] [review]
[treeherder] mozilla:rm-pyinotify > mozilla:master
Nope, I never tried to use that feature anyway. :)
Attachment #8750685 -
Flags: review?(cdawson) → review+
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/34b107fe118781a68dd1c871d4da0f003f1d24a8
Bug 1175757 - Remove unused pyinotify dependency from dev.txt
Since the celery auto-reload feature which it enables hasn't been
working for some time regardless:
https://github.com/celery/celery/issues/1658
https://github.com/celery/celery/issues/1025
https://github.com/celery/celery/issues/1880
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: Treeherder: Docs & Development → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•