Try build feature needs whitespace: pre;

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: BenWa, Assigned: mdoglio)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8623971 [details]
Screenshot 2015-06-17 20.06.08.png

See the screenshot. It would make the error message easier to read
Assignee: nobody → mdoglio
Priority: -- → P1
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

mozreview: fix typo in TryField; r?dminor
Attachment #8680658 - Flags: review?(dminor)
(Assignee)

Comment 2

3 years ago
Created attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r?dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Attachment #8680659 - Flags: review?(dminor)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r?dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..

Comment 4

3 years ago
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

https://reviewboard.mozilla.org/r/23655/#review21181
Attachment #8680658 - Flags: review?(dminor) → review+

Comment 5

3 years ago
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

https://reviewboard.mozilla.org/r/23657/#review21183

Nice!
Attachment #8680659 - Flags: review?(dminor) → review+
(Assignee)

Comment 6

3 years ago
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

mozreview: fix typo in TryField; r=dminor
Attachment #8680658 - Attachment description: MozReview Request: mozreview: fix typo in TryField; r?dminor → MozReview Request: mozreview: fix typo in TryField; r=dminor
(Assignee)

Comment 7

3 years ago
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r=dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Attachment #8680659 - Attachment description: MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r?dminor → MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor
(Assignee)

Comment 8

3 years ago
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

mozreview: fix typo in TryField; r=dminor
(Assignee)

Comment 9

3 years ago
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r=dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.