Closed Bug 1175759 Opened 6 years ago Closed 6 years ago

Try build feature needs whitespace: pre;

Categories

(MozReview Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: BenWa, Assigned: mdoglio)

Details

Attachments

(3 files)

See the screenshot. It would make the error message easier to read
Assignee: nobody → mdoglio
Priority: -- → P1
Status: NEW → ASSIGNED
mozreview: fix typo in TryField; r?dminor
Attachment #8680658 - Flags: review?(dminor)
mozreview: convert nl to br in try error message (bug 1175759); r?dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Attachment #8680659 - Flags: review?(dminor)
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r?dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

https://reviewboard.mozilla.org/r/23655/#review21181
Attachment #8680658 - Flags: review?(dminor) → review+
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

https://reviewboard.mozilla.org/r/23657/#review21183

Nice!
Attachment #8680659 - Flags: review?(dminor) → review+
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

mozreview: fix typo in TryField; r=dminor
Attachment #8680658 - Attachment description: MozReview Request: mozreview: fix typo in TryField; r?dminor → MozReview Request: mozreview: fix typo in TryField; r=dminor
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r=dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Attachment #8680659 - Attachment description: MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r?dminor → MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor
Comment on attachment 8680658 [details]
MozReview Request: mozreview: fix typo in TryField; r=dminor

mozreview: fix typo in TryField; r=dminor
Comment on attachment 8680659 [details]
MozReview Request: mozreview: convert nl to br in try error message (bug 1175759); r=dminor

mozreview: convert nl to br in try error message (bug 1175759); r=dminor

The changedescription object corresponding to an autoland to try failure
will render \n characters as <br /> to maintain the original formatting.
In case of a very long error message this shouldn't be a problem as the
changedescription panels can be collapsed.
The autoland panel at the bottom of the commit table cannot be collapsed,
so I decided to only show the first line of content and place the full
error message in the title of the span containing it..
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.