1175769 - Invalid ipv6 URLs are treated as valid.

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect, P5)

Description

[Mark Hammond [:markh] [:mhammond]]

From bug 1107883:

> strings such as "![64:ff9b::8.8.8.8]" or "!@[2607:f0d0:1002:51::4]" are
> now considered valid URLs.

and they shouldn't be.

Comment 1

[:Gijs (he/him)]

This is surprising to me... is the uriFixup code getting this wrong?

Comment 2

[bassam lababidi [:bassam]]

I am looking forward to developing bug fixes. I would like to have this bug report assigned to me so I can work on it

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to bassam from comment #2)
> I am looking forward to developing bug fixes. I would like to have this bug
> report assigned to me so I can work on it

That's great! Please upload a patch and if it is going in the correct direction we'll happily assign this bug to you. In the mean time, feel free to ask any questions you have.

Comment 4

[bassam lababidi [:bassam]]

Mark, as per your second example "!@[2607:f0d0:1002:51::4]", it looks to me as a valid URI with HTTP authentication with "!" being the username. it's not a valid case for our problem.

The first one, though, is.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Gijs tells me :bassam found this to be tricker than it looks, and I agree :( With these URLs we enter nsDefaultURIFixup::KeywordURIFixup() and don't think it is an IPv6 URL, but *do* think the hostname is valid (as aFixupInfo->mFixedURI->GetAsciiHost() happily returns "![2001:db8::1]". None of the other heuristics in KeywordURIFixup() kick in, so we continue to treat it as a valid URL.

It *might* be possible to try and second-guess this code and have _matchUnknownUrl() in UnifiedComplete.js detect this case, but that's likely to be hacky and fragile.

I've no time to dig further into this at the moment. :bassam, thanks for having a look though.

Comment 6

[Marco Bonardo [:mak]]

not blocking the release of unified complete

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.