1175771 - Remove PL_DHashTableEnumerate() use from netwerk/

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nicholas Nethercote [inactive]]

Because PLDHashTable::Iterator is nicer than PL_DHashTableEnumerate().

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Fix indentation in nsHostResolver::FlushCache()

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove PL_DHashTableEnumerate() use from nsHostResolver

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: |diff -w| version of part 2

Here's a |diff -w| version of part 2 that should be easier to review, because it hides changes in indentation.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Replace nsCacheEntryHashable::VisitEntries() with iterators

Note that FreeCacheEntries was unused, and so could be removed as well.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3123ce2bf40f
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7992bd02bd0
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1a2bf4694e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3123ce2bf40f
https://hg.mozilla.org/mozilla-central/rev/a7992bd02bd0
https://hg.mozilla.org/mozilla-central/rev/4e1a2bf4694e