PositionCoord typedef in nsComputedStyle.cpp conflicts with one in nsRuleNode.cpp

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8624030 [details] [diff] [review]
patch

In nsComputedStyle.cpp we have:

  typedef const nsStyleBackground::Position::Coord PositionCoord;

and in nsRuleNode.cpp:

  typedef nsStyleBackground::Position::PositionCoord PositionCoord;

both at the top level, and these conflict when unified compilation brings these two files into the same translation unit.

I think we can just get rid of the typedef in nsComputedStyle.cpp (and the other two near it), as they're not bringing much benefit anyway.
Attachment #8624030 - Flags: review?(bzbarsky)
(Assignee)

Updated

3 years ago
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 8624030 [details] [diff] [review]
patch

r=me
Attachment #8624030 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/d80bdc49a0d5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.