Closed
Bug 1175819
Opened 9 years ago
Closed 9 years ago
[Contacts][NGA] Extract 'getLength' functionality to contacts_buttons .js class
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S1 (26Jun)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: mancas, Assigned: mancas)
References
Details
(Whiteboard: [NG Gaia Contacts])
Attachments
(1 file)
We need to extract from contact.js the functionality not related with contacts, in order to have a reusable and modular code. In this bug we will move the 'getLength' function, which it's only used in contacts_buttons.js
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → b.mcb
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → NGA S3 (26Jun)
|
|
Assignee | |
Comment 1•9 years ago
|
||
Hey Francisco! Can you take a quick look at the code?
Attachment #8624074 -
Flags: review?(francisco)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8624074 [details] [review] 'getLength' function has been extracted Pretty straigh forward change, thanks!
Attachment #8624074 -
Flags: review?(francisco) → review+
|
|
||
Comment 3•9 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/9e9fa37e4f505b17d3643a216074b78a18964cc4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
status-b2g-master:
--- → fixed
|
|
||
Comment 4•9 years ago
|
||
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in
before you can comment on or make changes to this bug.
Description
•