1175831 - Privacy Panel does not use new PasscodeHelper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Frederik Braun [:freddy]]

The privacy panel needs to use the new passcodehelper to set and check lockscreen passcodes. This is necessary because FxOS switched to hashed passcodes and the privacy panel sets an old-style passcode. Otherwise it will not work.
(https://github.com/mozilla-b2g/gaia/blob/master/shared/js/passcode_helper.js).


This was punted because the panel is not enabled by default.

I can take a stab later, but I will need someone to review this, code, since there are no tests for this.
If there were, they would be red by now.

Comment 1

[Frederik Braun [:freddy]]

Attachment: github pull request

All operations on the lockscreen Passcode now go through the PasscodeHelper, which returns a promise.
* I have rewritten few functions that relied on a synchronous flow so that they support this asynchronous style.
* I have removed observers for the passcode value and replaced them with a call to check().
* Checks on the passcode now only return true or false, so the error granularity in verifyPasscode (auth.js line 348) has become a bit smaller.

I have not run any tests yet, as I am still trying to figure out how to enable this app for my build environment. 

Marta, can you help me with getting the tests to run? 
I will flag you again for review once I'm completely finished.

Comment 2

[marta]

Thanks for taking care of this, freddy. I can review the code, but I cannot currently write any code (contract requirements..).

As for the app to run, it should be enabled by flashing the phone with engineering builds and a flag.

Comment 3

[Frederik Braun [:freddy]]

Thanks Marta, Looking forward to your review (a pull request is already attached).

Comment 4

[Frederik Braun [:freddy]]

Dave, what do you think: Should we still request checkin or go ahead with the split first. Is there a bug for the split?

Comment 5

[Dave Huseby [:huseby]]

I'm trying to back the privacy panel out.  Is that what you mean by "the split"?  The back-out bug is Bug 1182129.

Comment 6

[Frederik Braun [:freddy]]

Yes. I was referring to the back-out.

Comment 7

[Frederik Braun [:freddy]]

Resolved via bug 1182129.