1175836 - [Shinano][Aries][Flame] Wrong gps.conf picked up during build

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

We are reusing gps.conf from KK device blobs. Yet, checking the resulting file in out/target/product/aries/system/etc/gps.conf shows we are somehow not copying the good one.

Further checking shows:
> rm out/target/product/aries/system/etc/gps.conf && ./build.sh out/target/product/aries/system/etc/gps.conf

This copies the GOOD (from device blobs) gps.conf

> rm out/target/product/aries/system/etc/gps.conf && ./build.sh gps.conf

This copies the BAD (not from device blobs) gps.conf. In this case, the make target in action is from hardware/qcom/gps/etc/Android.mk and it copies the hardware/qcom/gps/etc/gps.conf file.

This is impacting Z3/Z3 Compact and Flame KK as far as I could check.

The |gps.conf| target probably comes from device/qcom/common/common.mk that is injecting GPS_HARDWARE (which contains it) into PRODUCT_PACKAGES.

Comment 1

[:gerard-majax]

On a Flame tree:
> $ sha1sum vendor/t2m/flame/proprietary/etc/gps.conf out/target/product/flame/system/etc/gps.conf hardware/qcom/gps/etc/gps.conf
> bda3777cf59fd33b946b420ae714ef0ccf05f75b  vendor/t2m/flame/proprietary/etc/gps.conf
> a5c3f73f5fbae0ddc99e29638fa789adc71e6908  out/target/product/flame/system/etc/gps.conf
> a5c3f73f5fbae0ddc99e29638fa789adc71e6908  hardware/qcom/gps/etc/gps.conf

On a Z3 Compact tree:
> $ sha1sum vendor/sony/aries/proprietary/etc/gps.conf out/target/product/aries/system/etc/gps.conf hardware/qcom/gps/etc/gps.conf 
> 0ae0a26587e4decfb34c6874e9245cac97d6ff86  vendor/sony/aries/proprietary/etc/gps.conf
> a5c3f73f5fbae0ddc99e29638fa789adc71e6908  out/target/product/aries/system/etc/gps.conf
> a5c3f73f5fbae0ddc99e29638fa789adc71e6908  hardware/qcom/gps/etc/gps.conf

Comment 2

[:gerard-majax]

So on Flame it's not such a big deal, since the differences lies in comments. It might be problematic once we want to make changes, though. On Z3/Z3 Compact, the configuration is really different, so it's probably breaking A-GPS feature.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I'm not sure I understand; where should we be getting the etc/gps.conf from?

As far as I know it is currently pulling from hardware/qcom/gps/etc/gps.conf
http://git.mozilla.org/?p=external/caf/platform/hardware/qcom/gps.git;a=summary

Are we suppose to pull from a different location?

Comment 4

[:gerard-majax]

I'll explain once (if ever even...)  i get to whistler.  But basically we gecko don't use this.