Closed Bug 1175895 Opened 4 years ago Closed 4 years ago

automation tier start message buffered by make

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(2 files)

On windows where we enable output buffering, the TIER_START message is buffered by make along with the rest of the output for each automation step. So for example, buildsymbols will run for several minutes, then make prints the tier start + all buildsymbols output + tier finish all at once. As far as mach knows, the buildsymbols step only ran for the time it took to print the output, which means its stat tracking is inaccurate.
Blocks: 1159832
This just aids the greppability of MOZ_AUTOMATION_* - for example, looking up MOZ_AUTOMATION_UPDATE_PACKAGING in dxr would have you believe that it's only used for partial updates, but moz-automation.mk also uses it for complete mar generation.
Attachment #8624201 - Flags: review?(ted)
Separate the tier start message into a different target. This forces make to flush it to stdout before the automation step starts running, so mach can get accurate stats.
Attachment #8624202 - Flags: review?(ted)
Comment on attachment 8624201 [details] [diff] [review]
0001-Bug-1175895-aid-greppability-of-MOZ_AUTOMATION_.patch

Review of attachment 8624201 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/moz-automation.mk
@@ +55,5 @@
> +  MOZ_AUTOMATION_PRETTY_UPDATE_PACKAGING \
> +  MOZ_AUTOMATION_L10N_CHECK \
> +  MOZ_AUTOMATION_PRETTY_L10N_CHECK \
> +  MOZ_AUTOMATION_UPLOAD \
> +  MOZ_AUTOMATION_SDK \

You could alternately just wrap this whole block in an `$(addprefix MOZ_AUTOMATION_,`, but gnu make is terrible so whatever.
Attachment #8624201 - Flags: review?(ted) → review+
Attachment #8624202 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/77d5a7ca90c5
https://hg.mozilla.org/mozilla-central/rev/c28f6bfc72c1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.