1175897 - Firefox for iOS (Build 22): "Send Tab" appears twice and not localized

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot build22

+++ This bug was initially created as a clone of Bug #1157241 +++

Send Tab is currently appearing twice and not localized.

Comment 1

[Stefan Plewako [:stef]]

I don't see it twice on my iPhone 5s, only unlocalized.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

There are two Send Tab strings:

Extensions/SendTo/Info.plist
Extensions/SendTo/SendTo.strings

The first is the name of the Send Tab action in the Share menu.
The second is the title of the modal view that shows up when you select the Send Tab action.

I can provide screenshots of both. Let me know.

I'm looking into why this is not appearing localized.

Comment 3

[Francesco Lodolo [:flod]]

Not sure what the question is. I just tried with simulator:
* If I import the Italian XLIFF file in XCode, I have one Send tab and it's perfectly localized.
* If I import using scripts/import-locales.sh, same result.

But strings on SVN changed in the last week, so not sure if that's the reason it got fixed from the current Testflight build.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

:flod I am confused. What did you see correctly localized? The title of the dialog or the title under the button/icon in the (system-provided) Share menu?

(I'm pretty sure the action title in the share menu is not localized - i almost have a patch for that)

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Simulator screenshot

Both if I understand the question. The only weirdness is the first device being identified as $(MOZ_BUNDLE_DISPLAY_NAME) in the list of devices

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/642

TL;DR The Send Tab action title is now correctly localized when presented in the system-provided Share sheet.

This patch fixes a couple of things:

* We never correctly converted Info.plist sections in the XLIFF to a `.strings` file. They would end up in the project as `XX.lproj/Info.plist`, which is wrong. They are now written to `XX.lproj/InfoPlist.strings` so that the strings are correctly picked up by iOS.
* The `xliff-cleanup.py` script was broken and I think it never correctly processed `Info.plist` sections anyway.
* The l10n scripts normally ignore the `CFBundleDisplayName` but we now make an exception if that key is found in `Extensions/SendTo/Info.plist`

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I don't understand why that worked for you. It should not work. It most certainly did not work for me in Dutch :-/

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This patch also makes sure the NSLocationWhenInUseUsageDescription key is output to Client/XX.lproj/InfoPlist.strings. I don't think it correctly worked before.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Stefan Arentz [:st3fan] from comment #7)
> I don't understand why that worked for you. It should not work. It most
> certainly did not work for me in Dutch :-/

Are those strings translated for Dutch? Maybe it's same weird XCode caching from when I tried to import the file from within XCode (but I also always run "git clean -fd" in the repo).

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 8626823 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/642

Freaking XCode cache... Did Product->Clean and the button was in English. Patched version works as expected.