On tablet when the page is shorter than the screen size you see a grey background underneath the white footer. On desktop we make the background colour white  so if this happens the footer seems to take the rest of the page content. We should update the desktop background colour to be the default when the footer is visible. See ValentinaP's screenshots  for examples.  https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L265  http://screencast.com/t/DrCpAQy4r
I want to work on this :) Can u help me out? :)
Hi Mark, could you please help Zunaid on this ?
Status: NEW → ASSIGNED
The rule that sets the background color to white  should move from the `@media $base-desktop` block up to the `@media $base-tablet` block.  https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L264-L266
Created attachment 8635667 [details] [review] pull request Please, review the pr :)
Attachment #8635667 - Flags: review?(mstriemer)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8635667 - Flags: review?(mstriemer) → review+
You need to log in before you can comment on or make changes to this bug.