Tablet background colour should be white under footer

RESOLVED FIXED

Status

P4
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mstriemer, Assigned: zunaid321, Mentored)

Tracking

Avenir
Points:
---

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
mstriemer
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
On tablet when the page is shorter than the screen size you see a grey background underneath the white footer. On desktop we make the background colour white [1] so if this happens the footer seems to take the rest of the page content. We should update the desktop background colour to be the default when the footer is visible.

See ValentinaP's screenshots [2] for examples.

[1] https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L265
[2] http://screencast.com/t/DrCpAQy4r
(Reporter)

Updated

4 years ago
See Also: → bug 1171831
(Assignee)

Comment 1

4 years ago
I want to work on this :) Can u help me out? :)
Assignee: nobody → softfilebd
Hi Mark, could you please help Zunaid on this ?
Status: NEW → ASSIGNED
Flags: needinfo?(mstriemer)
Assignee: softfilebd → zunaid321
(Reporter)

Comment 3

3 years ago
The rule that sets the background color to white [1] should move from the `@media $base-desktop` block up to the `@media $base-tablet` block.

[1] https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L264-L266
Flags: needinfo?(mstriemer)
(Assignee)

Comment 4

3 years ago
Created attachment 8635667 [details] [review]
pull request

Please, review the pr :)
Attachment #8635667 - Flags: review?(mstriemer)

Comment 5

3 years ago
https://github.com/mozilla/fireplace/pull/1399
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Attachment #8635667 - Flags: review?(mstriemer) → review+
You need to log in before you can comment on or make changes to this bug.