1175918 - Tablet background colour should be white under footer

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Mark Striemer [:mstriemer]]

On tablet when the page is shorter than the screen size you see a grey background underneath the white footer. On desktop we make the background colour white [1] so if this happens the footer seems to take the rest of the page content. We should update the desktop background colour to be the default when the footer is visible.

See ValentinaP's screenshots [2] for examples.

[1] https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L265
[2] http://screencast.com/t/DrCpAQy4r

Comment 1

[Zunaid Amin Enan]

I want to work on this :) Can u help me out? :)

Comment 2

[Ram Dayal Vaishnav [:ram]]

Hi Mark, could you please help Zunaid on this ?

Comment 3

[Mark Striemer [:mstriemer]]

The rule that sets the background color to white [1] should move from the `@media $base-desktop` block up to the `@media $base-tablet` block.

[1] https://github.com/mozilla/fireplace/blob/50188394673f0d0e0297e09ea3670f6a782f0563/src/media/css/site.styl#L264-L266

Comment 4

[Zunaid Amin Enan]

Attachment: pull request

Please, review the pr :)

Comment 5

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/1399