Closed Bug 1175941 Opened 4 years ago Closed 4 years ago

SHOW under the password doorhanger flickers sometimes

Categories

(Toolkit :: Password Manager, defect)

41 Branch
All
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla42
Iteration:
42.2 - Jul 27
Tracking Status
firefox40 --- unaffected
firefox41 + verified
firefox42 + verified

People

(Reporter: kjozwiak, Assigned: rittme)

References

Details

(Keywords: reproducible, Whiteboard: pwmgr42)

Attachments

(2 files)

While hovering over the password field, the highlighted word "SHOW" will sometimes have a black background quickly appear/disappear making it look like it flickered. I could only reproduce this on OSX so not 100% sure it's happening on other platforms. It's not easily reproducible but definitely happens here and there. I noticed that you can get it to reproduce a lot easier if you close the doorhanger initially and then bring it back by clicking on the "key".

Attached a quick video of the issue (the "flicker" happens near the end of the video)

- https://youtu.be/GNHFcmTYd_Y

This is really trivial so not sure if it's worth fixing but users will definitely be able to tell when it happens.
Attached image error.png
Sometimes items/text etc.. that are behind "SHOW" and the door hanger quickly appear in the foreground. This was really hard to capture but I managed to get a screenshot. In this case, I went over "SHOW" several times and noticed something really large flicker and disappear instantly.
Apologies for the spam, here's the video of the issue from comment # 1 happening:

- https://youtu.be/qup3K-Iyi7M?t=18s
[Tracking Requested - why for this release]: Poor UX for a new feature

Thank Kamil, I've also seen this and it's fairly easy to reproduce. It looks like a graphics problem to me.
Component: Password Manager → Graphics
Keywords: reproducible
Product: Toolkit → Core
Hardware: x86 → All
:milan - could you investigate this - this is a blocker for password manager
Flags: needinfo?(milan)
(In reply to Matthew N. [:MattN] from comment #3)
> [Tracking Requested - why for this release]: Poor UX for a new feature

When did this show up as a feature, and has it been the problem from the first day that it showed up?
Flags: needinfo?(milan)
Whiteboard: [gfx-noted]
Regression window here would help
(In reply to Milan Sreckovic [:milan] from comment #5)
> (In reply to Matthew N. [:MattN] from comment #3)
> > [Tracking Requested - why for this release]: Poor UX for a new feature
> 
> When did this show up as a feature, and has it been the problem from the
> first day that it showed up?

It showed up in 41 from the initial landing in bug 1169702.

Finding a regression range would be non-trivial since I don't know of other browser features that would exhibit the bug before bug 1169702 landed. It's easy to reproduce so I suspect debugging it is easier in this case.
Yeah, it also means this may just be trying to either do the wrong thing, or require new functionality.
I'm pretty sure this was a regression in OS X itself from 10.9 to 10.10.
It's really tricky to work around if we want to keep the shadow under the panel. Switching to OpenGL for compositing panel contents will get rid of the flickering and lose the shadow.
So we'll need to do some extra work to make sure we get correct shadows. Bug 1036929 and bug 1062271 are existing bugs tracking this work. This probably won't even make it into 42.
Is 42 affected as well? If so, can we set the appropriate flags? Based on the last comment, this is not something that will be uplifted into 41?
Flags: needinfo?(MattN+bmo)
(In reply to Kate Glazko from comment #10)
> Is 42 affected as well?

Yes
Flags: needinfo?(MattN+bmo)
(In reply to Markus Stange [:mstange] from comment #9)
> I'm pretty sure this was a regression in OS X itself from 10.9 to 10.10.

Do you think this is related to the transition on the SHOW text? If so, we could maybe workaround by removing or changing the transition?
I think the transition just increases the chances of hitting a "bad" window refresh because you're triggering more paints. So removing the transition would at least decrease the number of times that users would hit the problem.
Tracking for 41, 41 because regression.
Not a Gecko regression, this is new functionality.  Could track it as an OS X regression though.
Alright, I saw the regression flag set- tracking because OS X regression and affected. Keep posted on the status of any potential fixes.
I'll talk to mattn to figure out our options here.
In speaking with mattn, rfeeley, kamil: we're going to move forward with disabling the transition on mac 10.10.  Kamil is going to test more on Win and older Mac versions.
Component: Graphics → Password Manager
Product: Core → Toolkit
(In reply to Markus Stange [:mstange] from comment #13)
> I think the transition just increases the chances of hitting a "bad" window
> refresh because you're triggering more paints. So removing the transition
> would at least decrease the number of times that users would hit the problem.

Has anyone noticed this anywhere in 10.10? Because we have a variety of places in panels where we are doing transitions. e.g. the application menu sub-panel slide.
(In reply to Stephen Horlander [:shorlander] from comment #19)
> (In reply to Markus Stange [:mstange] from comment #13)
> > I think the transition just increases the chances of hitting a "bad" window
> > refresh because you're triggering more paints. So removing the transition
> > would at least decrease the number of times that users would hit the problem.
> 
> Has anyone noticed this anywhere in 10.10? Because we have a variety of
> places in panels where we are doing transitions. e.g. the application menu
> sub-panel slide.

meant to say *anywhere else in 10.10 :)
I remember seeing a bug filed about the fact that the jumping whimsycorn in the australis hamburger panel hits this, but I can't find the bug anymore.
> In speaking with mattn, rfeeley, kamil: we're going to move forward with
> disabling the transition on mac 10.10.  Kamil is going to test more on Win
> and older Mac versions.

So I played around with a bunch of Win machines (not VM's) and couldn't reproduce the problem:

- Win 8.1 x64 -> Couldn't Reproduce
- Win 7 Pro x64 -> Couldn't Reproduce
- Win Vista x64 -> Couldn't Reproduce

I have OSX 10.7.5, 10.8.5 and 10.9.5 on a VM but unfortunately I have to wait for Bug # 1180688 to land in m-c as the entire browser just appears as a white blank page.
Bug 1175941 - Disable capture doorhangers SHOW label transition
Disabling transitions on the SHOW label seem to have stopped the flickering. However, there are still some rare flickers happening when I hover the doorhanger textboxes on my machine. I tried removing the SHOW  entirely but it doesn't help, so I think they are unrelated. I filled bug 1183442 for that issue.
Assignee: nobody → bernardo
Status: NEW → ASSIGNED
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

Bug 1175941 - Disable capture doorhangers SHOW label transition
Attachment #8633237 - Flags: review?(MattN+bmo)
Iteration: --- → 42.2 - Jul 27
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

https://reviewboard.mozilla.org/r/13191/#review11879

::: browser/base/content/browser.css:1362
(Diff revision 1)
> +@media (-moz-mac-yosemite-theme) {
> +  #password-notification-password::after {

Add a comment about why this is disabled with a bug number. e.g.:
Bug 1175941: Disable the transition on 10.10 due to flickering possibly due to an OS X bug.
Attachment #8633237 - Flags: review?(MattN+bmo) → review+
Attachment #8633237 - Flags: review+ → review?(MattN+bmo)
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

Bug 1175941 - Disable capture doorhangers SHOW label transition
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

https://reviewboard.mozilla.org/r/13191/#review11985

Ship It!
Attachment #8633237 - Flags: review?(MattN+bmo) → review+
Keywords: checkin-needed
Flags: qe-verify+
QA Contact: kjozwiak
https://hg.mozilla.org/mozilla-central/rev/4c2683a6a34e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Reproduced the original issue using the following m-c build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-07-15-09-55-06-mozilla-central/

* Reproduced the issue pretty easily and noticed the background flickering behind the "SHOW" string under the doorhanger several times

Went through verification using the following m-c build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-07-23-03-02-07-mozilla-central/

* Couldn't reproduce the flicker behind the "SHOW" string with the latest m-c
* spent about 10 minutes moving the mouse over SHOW and didn't see any flickers (it's pretty easy to reproduce so it looks like it's definitely ficked)

OS's Used:

- OSX 10.10.4 x64 - PASSED
- Win 8.1 x64 - PASSED

As Bernardo mentioned in comment 24 (bug 1183442), there's still some cases where there's a flicker when hovering over the password text box. Is this going to be uplifted into m-a or will it just take the train during the next release?
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

Approval Request Comment
[Feature/regressing bug #]: This fixes flickering in the feature from bug 1169702.
[User impact if declined]: OS X 10.10 users will sometimes see flickering when they hover the password textbox at the password manager capture doorhanger.
[Describe test coverage new/current, TreeHerder]: Manually tested and verified by Kamil. Has been on nightly for some days. 
[Risks and why]: Low risk, because it's disabling a single CSS transition on OS X 10.10 only.
[String/UUID change made/needed]: none
Attachment #8633237 - Flags: approval-mozilla-aurora?
Comment on attachment 8633237 [details]
MozReview Request: Bug 1175941 - Disable capture doorhangers SHOW label transition

Fix has been verified, one-liner CSS only patch. Let's uplift to Aurora.
Attachment #8633237 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [gfx-noted] → pwmgr42
Went through verification using the following m-a build:

- https://ftp.mozilla.org/pub/firefox/nightly/2015-07-31-00-40-08-mozilla-aurora/

* Win 10 x64 (10.0.10240) - PASSED
* Win 8.1 x64 (6.3.9600) VM - PASSED
* OSX 10.10.4 x64 - PASSED (bug 1183442 also occurring on m-a)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.