1175969 - Update tracking protection settings item to only be about private browsing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

We should be able to just update this pref to "privacy.trackingprotection.pbmode.enabled", and we'll need to update the string in the settings UI.

Comment 1

[Chenxia Liu [:liuche]]

The string for this should be:

Tracking protection
Actively block tracking elements in Private Browsing

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: Update tracking protection settings item to only be about private browsing

Wasn't quite sure how to test the pref change - any ideas?  I've implemented the changes as suggested

Comment 3

[Chenxia Liu [:liuche]]

testSettingsMenuItems is still broken on 4.3, and crashing on 2.3, but it's still running on 4.0 if you make try push. I would add it to that test.

You can also manually test - espn.go.com always seems to have tracking elements, so open that in PB and also regular.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8627673 [details] [diff] [review]
Update tracking protection settings item to only be about private browsing

Review of attachment 8627673 [details] [diff] [review]:
-----------------------------------------------------------------

This looks about right. I second what liuche suggested - I would just go to a page with trackers in a private tab (most publishers should have them).

As part of this patch, you could also set the default pref value to true in mobile.js, and you could remove the logic that makes this visible pref Nightly-only so that it will ride the trains. Choo choo!

Comment 5

[Martyn Haigh (:mhaigh)]

Attachment: Update tracking protection settings item to only be about private browsing

Tested on espn.com (and a couple of other sites) and in PB I see a distinct lack of adverts!

I've removed the nightly flag from this feature, amended the test and set the default to true in mobile.js.

Go Tracking Protection!!

Comment 6

[:Margaret Leibovic]

Comment on attachment 8628778 [details] [diff] [review]
Update tracking protection settings item to only be about private browsing

Review of attachment 8628778 [details] [diff] [review]:
-----------------------------------------------------------------

One small piece of feedback, but r+ with that addressed.

::: mobile/android/app/mobile.js
@@ +275,5 @@
>  // disable updating
>  pref("browser.search.update", false);
>  
> +// enable tracking protection for private browsing
> +pref("privacy.trackingprotection.pbmode.enabled", true);

\o/

::: mobile/android/base/preferences/GeckoPreferences.java
@@ +123,5 @@
>      private static final String PREFS_DEVTOOLS_REMOTE_ENABLED = "devtools.debugger.remote-enabled";
>      private static final String PREFS_DISPLAY_REFLOW_ON_ZOOM = "browser.zoom.reflowOnZoom";
>      private static final String PREFS_DISPLAY_TITLEBAR_MODE = "browser.chrome.titlebarMode";
>      private static final String PREFS_SYNC = NON_PREF_PREFIX + "sync";
> +    private static final String PREFS_TRACKING_PROTECTION = "privacy.trackingprotection.pbmode.enabled";

We can get rid of this variable altogether, as it look like it's only used in the if statement below. Same goes for the PREFS_TRACKING_PROTECTION_LEARN_MORE variable.

Comment 7

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b1a2980bf7d

Comment 8

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/1cd47a2d10f6

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1cd47a2d10f6

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-07-22-11-04-04.png

Verified fixed using:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 42.0a1 (2015-07-20)

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2015-09-22 18:04:08.png

Verified as fixed using:
Device: Samsung s6 (Android 5.1)
Builds: Firefox for Android 42 beta 1, 43.0a2 and 44.0a1 (2015-09-21)