Closed
Bug 1176006
Opened 9 years ago
Closed 9 years ago
Add test coverage for sending persisted deletion pings
Categories
(Toolkit :: Telemetry, defect, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
People
(Reporter: gfritzsche, Unassigned)
References
Details
(Whiteboard: [measurement:client])
If we can send a deletion ping right away, bug 1120379 works fine. If sending fails etc. and we end up persisting the deletion ping, we hit canSend() checks that were not updated. While i'm probably fixing this in bug 1156359, this shows that we are missing test coverage here.
Updated•9 years ago
|
Reporter | ||
Updated•9 years ago
|
Points: --- → 1
Priority: -- → P3
Whiteboard: [measurement:client]
Reporter | ||
Comment 1•9 years ago
|
||
ni?dexter to check if we already cover this.
Flags: needinfo?(alessio.placitelli)
Comment 2•9 years ago
|
||
We are covering this test case in test_TelemetryController.js [1]. [1] - https://dxr.mozilla.org/mozilla-central/rev/f029ccdee154bdc2b49a1e0fcd5b0fa0397aa97b/toolkit/components/telemetry/tests/unit/test_TelemetryController.js#160
Flags: needinfo?(alessio.placitelli)
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•