1176009 - Log results when associating ldap usernames with Review Board accounts

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: log ldap associations (bug 1176009) r?smacleod

mozreview: log ldap associations (bug 1176009) r?smacleod

This adds a log statement for each ldap association that is made.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8643891 [details]
MozReview Request: mozreview: log ldap associations (bug 1176009) r?smacleod

https://reviewboard.mozilla.org/r/15165/#review14197

::: pylib/mozreview/mozreview/ldap/resources.py:153
(Diff revision 1)
> +        logging.info('associating user: %s with ldap_username: %s' % (user,
> +            ldap_username))

Should we also be logging the IP address that requested this, etc? or can we determine that from other things that will be in the log?

I'm fine with this landing as is but we might want to figure out if we should be doing more.

Comment 3

[Dan Minor [:dminor]]

Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/38e5a18c791c

We have Bug 1091806 open to audit reviewboard logging which should help us figure out if this level of logging is sufficient or not. We should probably be logging ip addresses for every incoming request if we're not already.