Closed Bug 1176056 Opened 6 years ago Closed 5 years ago

Tests for JIT View

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set
normal

Tracking

(firefox41 affected, firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox41 --- affected
firefox47 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

More tests, more comprehensive tests, right now still an experiment so tests could be improved.

The previous optimization views in the call tree -- those tests have been disabled for now and need to be rewired up to the new view.
No longer blocks: perf-tools-fx43
No longer blocks: perf-tools-fx44
Attached patch 1176056-jit-tests.patch (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae9360d541b7

Looks like the autoDepthExpand didn't work. And the extra updateHeight() call is because without that, it wouldn't get the right size of the container to render all rows. Maybe a better way to do this?
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8713898 - Flags: review?(nfitzgerald)
xpcshell test failures, updated, added more tests for JIT model
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3817f966af09
Attachment #8713898 - Attachment is obsolete: true
Attachment #8713898 - Flags: review?(nfitzgerald)
Attachment #8714311 - Flags: review?(nfitzgerald)
Comment on attachment 8714311 [details] [diff] [review]
1176056-jit-tests.patch

Review of attachment 8714311 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!

::: devtools/client/performance/test/unit/test_jit-model-02.js
@@ +45,2 @@
>  
> +  /* isSuccessfulOutcome */

Why are we using /**/ comments in this file?
Attachment #8714311 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/61e210bd523c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.