Closed
Bug 1176056
Opened 7 years ago
Closed 6 years ago
Tests for JIT View
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 affected, firefox47 fixed)
RESOLVED
FIXED
Firefox 47
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
31.72 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
More tests, more comprehensive tests, right now still an experiment so tests could be improved. The previous optimization views in the call tree -- those tests have been disabled for now and need to be rewired up to the new view.
Updated•7 years ago
|
Blocks: perf-tools-fx43
Assignee | ||
Updated•7 years ago
|
No longer blocks: perf-tools-fx43
Assignee | ||
Updated•7 years ago
|
Blocks: perf-tools-fx44
Assignee | ||
Updated•7 years ago
|
No longer blocks: perf-tools-fx44
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae9360d541b7 Looks like the autoDepthExpand didn't work. And the extra updateHeight() call is because without that, it wouldn't get the right size of the container to render all rows. Maybe a better way to do this?
Assignee | ||
Comment 2•6 years ago
|
||
xpcshell test failures, updated, added more tests for JIT model https://treeherder.mozilla.org/#/jobs?repo=try&revision=3817f966af09
Attachment #8713898 -
Attachment is obsolete: true
Attachment #8713898 -
Flags: review?(nfitzgerald)
Attachment #8714311 -
Flags: review?(nfitzgerald)
Comment 3•6 years ago
|
||
Comment on attachment 8714311 [details] [diff] [review] 1176056-jit-tests.patch Review of attachment 8714311 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Thanks! ::: devtools/client/performance/test/unit/test_jit-model-02.js @@ +45,2 @@ > > + /* isSuccessfulOutcome */ Why are we using /**/ comments in this file?
Attachment #8714311 -
Flags: review?(nfitzgerald) → review+
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/61e210bd523c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•