1176056 - Tests for JIT View

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

More tests, more comprehensive tests, right now still an experiment so tests could be improved.

The previous optimization views in the call tree -- those tests have been disabled for now and need to be rewired up to the new view.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1176056-jit-tests.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae9360d541b7

Looks like the autoDepthExpand didn't work. And the extra updateHeight() call is because without that, it wouldn't get the right size of the container to render all rows. Maybe a better way to do this?

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1176056-jit-tests.patch

xpcshell test failures, updated, added more tests for JIT model
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3817f966af09

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8714311 [details] [diff] [review]
1176056-jit-tests.patch

Review of attachment 8714311 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!

::: devtools/client/performance/test/unit/test_jit-model-02.js
@@ +45,2 @@
>  
> +  /* isSuccessfulOutcome */

Why are we using /**/ comments in this file?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/61e210bd523c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61e210bd523c