Some graphs don't display properly

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

The graph linked off of this page:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=027bf5a1e5eb&newProject=try&newRevision=b015adea7c85&originalSignature=bb48078b6137f88afc52591b0e2aaa540435392c&newSignature=bb48078b6137f88afc52591b0e2aaa540435392c

Here:

https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800&series=[try,caaefc817cde76da2fbfd2820b663d598125c7c2,1]&highlightedRevisions=027bf5a1e5eb&highlightedRevisions=b015adea7c85

... seems to show the wrong dates/values for revision 027bf5a1e5eb (values of 14ish when it should be 24ish, date way too earlier). Turns out that this is because we weren't inserting the data into the graph in the correct order, so the resultset info was not correctly correlated with the shape of the graph. Fortunately this is easy to fix.
Created attachment 8624453 [details] [review]
PR
Attachment #8624453 - Flags: review?(jmaher)
Comment on attachment 8624453 [details] [review]
PR

oh, face palm.
Attachment #8624453 - Flags: review?(jmaher) → review+

Comment 3

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d822d44e5a14d68197089f5cd8f736ce21a10ac0
Bug 1176059 - Fix correlation of graphs with revision/result set info
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.