Closed Bug 1176073 Opened 5 years ago Closed 5 years ago

Crash: AssertWorkerThread() on main thread under netwerk

Categories

(Core :: Networking, defect)

Unspecified
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox40 --- fixed
firefox41 + fixed
firefox42 + fixed

People

(Reporter: luke, Assigned: jduell.mcbugs)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Just crashed with this stack:
  https://crash-stats.mozilla.com/report/index/98b96d47-4e95-4256-bd17-c73122150618
in current Nightly.
jason - this is deep in the bowels of ipc. Any idea where to go with it?
Flags: needinfo?(jduell.mcbugs)
Bill, 

:bent told me you're our new IPDL expert now that he's leaving.  Got any thoughts about how to fix this (especially w/o STR?).  Yuk.
Flags: needinfo?(jduell.mcbugs) → needinfo?(wmccloskey)
Well, PHttpChannel is part of PContent, which runs on the main thread. So we're clearly running on the correct thread. It seems like the MessageChannel is probably corrupted somehow, probably from being freed. It looks like there isn't the usual mIPCClosed check in ReportSecurityMessage. Could that be the problem?
Flags: needinfo?(wmccloskey)
Attached patch v1Splinter Review
> It looks like there isn't the usual mIPCClosed check in 
> ReportSecurityMessage. Could that be the problem?

Well, it's sure worth a try.
Assignee: nobody → jduell.mcbugs
Status: NEW → ASSIGNED
Attachment #8633725 - Flags: review?(honzab.moz)
Attachment #8633725 - Flags: review?(honzab.moz) → review+
Duplicate of this bug: 1182300
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bcc208c22c9e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Jason, could you request uplift to Aurora please? I suspect that we won't bother for Beta, but I'm requesting tracking anyway to let the release managers make the call.

[Tracking Requested - why for this release]: Moderate topcrash, 0.53% of crashes on 40b8
Flags: needinfo?(jduell.mcbugs)
Comment on attachment 8633725 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]:  unknown
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]:  usual mochitests/xpcshell
[Risks and why]: None
[String/UUID change made/needed]: none

This is a risk-free patch.  It adds a check that we're always supposed to do before doing IPC communication, the absence of which may be causing a crash.  We should uplift it.
Flags: needinfo?(jduell.mcbugs)
Attachment #8633725 - Flags: approval-mozilla-beta?
Attachment #8633725 - Flags: approval-mozilla-aurora?
Comment on attachment 8633725 [details] [diff] [review]
v1

This has been in m-c for a few days, let's uplift to Aurora and see if the crash goes away.
Attachment #8633725 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8633725 [details] [diff] [review]
v1

[Triage Comment]
Adding to approval-mozilla-release to make sure it lands in the 40 branch as we are going to do the m-b => m-r merge today.

Taking it as it this should improve the quality of the release.

However, Jason, I don't agree with your evaluation. Every patch introduced a risk... (I have many examples of bug with Risk: None which will break the tree)
Attachment #8633725 - Flags: approval-mozilla-release+
Attachment #8633725 - Flags: approval-mozilla-beta?
Attachment #8633725 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.