1176083 - kill nsJSScriptTimeoutHandler::Init

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tom Tromey :tromey]

This came from https://bugzilla.mozilla.org/show_bug.cgi?id=1148593#c52
There, bz wrote:

> nsJSScriptTimeoutHandler::Init... I think that code is basically dead.  We should kill
> it off; file a followup bug please?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the now-dead code for the XPCOM version of setTimeout/setInterval

I claim this code is dead because on the one hand it's no longer called from JS
(because Window is always on WebIDL bindings, but on the other hand it can't
really be called from C++ because it depends on examining the XPConnect call
information.

I think removing this completely, including from the IDL, is safe, because
nothing directly returns nsIDOMJSWindow, so anyone using its vtable would have
to QI to it and we're changing the IID.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the now-dead code for the XPCOM version of setTimeout/setInterval

I claim this code is dead because on the one hand it's no longer called from JS
(because Window is always on WebIDL bindings, but on the other hand it can't
really be called from C++ because it depends on examining the XPConnect call
information.

I think removing this completely, including from the IDL, is safe, because
nothing directly returns nsIDOMJSWindow, so anyone using its vtable would have
to QI to it and we're changing the IID.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8624592 [details] [diff] [review]
Remove the now-dead code for the XPCOM version of setTimeout/setInterval

Nice.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4267b74ee795

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4267b74ee795