Closed
Bug 1176090
Opened 10 years ago
Closed 10 years ago
Remove RelocatablePtr typedef and switch users over to HeapPtr
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
INVALID
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
31.12 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
As it says on the tin: rename all the RelocatablePtr to HeapPtr.
Attachment #8624501 -
Flags: review?(jcoppeard)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8624501 [details] [diff] [review]
rename_RelocatablePtr-v1.diff
Review of attachment 8624501 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/Barrier.h
@@ +132,5 @@
> * the "obj->field.init(value)" method instead of "obj->field = value". We use
> * the init naming idiom in many places to signify that a field is being
> * assigned for the first time.
> *
> * This file implements four classes, illustrated here:
*three* classes ;)
Attachment #8624501 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
|
Assignee | |
Comment 5•10 years ago
|
||
Backed out for now -- Bug 1174873 was causing crashes. Will fix this set of patches when I get home.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•10 years ago
|
||
As per bug 1174879.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•