Remove unused lang atoms (ko-xxx and x-symbol)

RESOLVED FIXED in Firefox 42

Status

()

Core
Graphics: Text
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: m_kato, Assigned: BenWa)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox41 affected, firefox42 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
ko-xxx was Gecko 1.8 era.

Also x-symbol seemed to be for bug 340590..
(Assignee)

Comment 1

3 years ago
Created attachment 8624870 [details] [diff] [review]
patch

I've got no idea who to pick for a reviewer and :vlad looked at bug 340590 so I pick you!

From what I understand there's no reference to these string, as reported in comment 0, so there's no way that these can be used AFAIK.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8624870 - Flags: review?(vladimir)
Attachment #8624870 - Flags: review?(vladimir) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c0e88129206
Keywords: checkin-needed
backed out for causing windows bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=11596303&repo=mozilla-inbound
Flags: needinfo?(bgirard)

Comment 4

2 years ago
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b14ae415db55
(Assignee)

Comment 5

2 years ago
Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched for the wrong string). I don't know enough about this code to know the implication of removing the code there.
Flags: needinfo?(bgirard) → needinfo?(m_kato)
(Reporter)

Comment 6

2 years ago
(In reply to Benoit Girard (:BenWa) from comment #5)
> Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched
> for the wrong string). I don't know enough about this code to know the
> implication of removing the code there.

This is unused too.  No one sets ko_xxx and x_symbols
Flags: needinfo?(m_kato)
(Reporter)

Comment 7

2 years ago
Created attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol
(Reporter)

Comment 8

2 years ago
Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

No one sets ko_xxx and x_symbol and these isn't used into gfxFontPrefLangList.h

So we can remove this.
Attachment #8633925 - Flags: review?(jdaggett)

Comment 9

2 years ago
Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

Review of attachment 8633925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8633925 - Flags: review?(jdaggett) → review+

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/523bc1e7f6f4
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad577f4bc278
https://hg.mozilla.org/mozilla-central/rev/523bc1e7f6f4
https://hg.mozilla.org/mozilla-central/rev/ad577f4bc278
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.