1176158 - Remove unused lang atoms (ko-xxx and x-symbol)

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Makoto Kato [:m_kato]]

ko-xxx was Gecko 1.8 era.

Also x-symbol seemed to be for bug 340590..

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

I've got no idea who to pick for a reviewer and :vlad looked at bug 340590 so I pick you!

From what I understand there's no reference to these string, as reported in comment 0, so there's no way that these can be used AFAIK.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c0e88129206

Comment 3

[Carsten Book [:Tomcat]]

backed out for causing windows bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=11596303&repo=mozilla-inbound

Comment 4

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b14ae415db55

Comment 5

[Benoit Girard (:BenWa)]

Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched for the wrong string). I don't know enough about this code to know the implication of removing the code there.

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Benoit Girard (:BenWa) from comment #5)
> Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched
> for the wrong string). I don't know enough about this code to know the
> implication of removing the code there.

This is unused too.  No one sets ko_xxx and x_symbols

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Part 2. Remove ko_xxx and x_symbol

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

No one sets ko_xxx and x_symbol and these isn't used into gfxFontPrefLangList.h

So we can remove this.

Comment 9

[John Daggett (:jtd)]

Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

Review of attachment 8633925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/523bc1e7f6f4
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad577f4bc278

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/523bc1e7f6f4
https://hg.mozilla.org/mozilla-central/rev/ad577f4bc278