Closed Bug 1176158 Opened 5 years ago Closed 5 years ago

Remove unused lang atoms (ko-xxx and x-symbol)

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox41 --- affected
firefox42 --- fixed

People

(Reporter: m_kato, Assigned: BenWa)

Details

Attachments

(2 files)

ko-xxx was Gecko 1.8 era.

Also x-symbol seemed to be for bug 340590..
Attached patch patchSplinter Review
I've got no idea who to pick for a reviewer and :vlad looked at bug 340590 so I pick you!

From what I understand there's no reference to these string, as reported in comment 0, so there's no way that these can be used AFAIK.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8624870 - Flags: review?(vladimir)
Keywords: checkin-needed
backed out for causing windows bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=11596303&repo=mozilla-inbound
Flags: needinfo?(bgirard)
Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched for the wrong string). I don't know enough about this code to know the implication of removing the code there.
Flags: needinfo?(bgirard) → needinfo?(m_kato)
(In reply to Benoit Girard (:BenWa) from comment #5)
> Looks like they are used in gfx/thebes/gfxGDIFontList.h (must of searched
> for the wrong string). I don't know enough about this code to know the
> implication of removing the code there.

This is unused too.  No one sets ko_xxx and x_symbols
Flags: needinfo?(m_kato)
Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

No one sets ko_xxx and x_symbol and these isn't used into gfxFontPrefLangList.h

So we can remove this.
Attachment #8633925 - Flags: review?(jdaggett)
Comment on attachment 8633925 [details] [diff] [review]
Part 2. Remove ko_xxx and x_symbol

Review of attachment 8633925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8633925 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/523bc1e7f6f4
https://hg.mozilla.org/mozilla-central/rev/ad577f4bc278
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.