Closed Bug 1176193 Opened 5 years ago Closed 5 years ago
Make the dialer (mostly) eslint-clean
46 bytes, text/x-github-pull-request
|Details | Review|
The dialer/callscreen apps contain a number of trivial eslint errors, let's clean them up ASAP.
These are mostly mechanical changes to get rid of various misuse of innerHTML. I've left two issues unfixed as they're both functional and will be done in bug 1081161 and bug 1060333.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8625057 [details] [review] [PULL REQUEST] Make the dialer, callscreen and emergency-call apps eslint-clean Looks good to me, but it looks like eslint is still failing. Can you address and re-flag me? Thanks!
Comment on attachment 8625057 [details] [review] [PULL REQUEST] Make the dialer, callscreen and emergency-call apps eslint-clean (In reply to Kevin Grandon (PTO) :kgrandon from comment #2) > Looks good to me, but it looks like eslint is still failing. Can you address > and re-flag me? Thanks! Thanks for the review, I had removed the shared file from the xfail list but forgot to fix it up. I've pushed another patch on top of the PR for ease of review; I'll squash them before landing.
Comment on attachment 8625057 [details] [review] [PULL REQUEST] Make the dialer, callscreen and emergency-call apps eslint-clean LGTM assuming that everything is nice and green on treeherder. The latest test run seems to have stalled, so I kicked it again. Thanks!
Attachment #8625057 - Flags: review?(kgrandon) → review+
I'm not sure what's wrong with the TV integration tests but I've squashed, rebased and pushed again so as to retrigger the tests once more. Let's see what happens now.
The TV integration tests must be broken, I've double-checked them and there's nothing here that should be causing them to fail so I've proceeded with the merge: https://github.com/mozilla-b2g/gaia/commit/f8a1a15d8e98b0316e8e89682bab9460838fdeed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.