Closed Bug 1176196 Opened 5 years ago Closed 5 years ago

Update libjpeg-turbo to version 1.4.2

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ionnv, Assigned: ted)

References

()

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

http://sourceforge.net/projects/libjpeg-turbo/files/1.4.1/

Libjpeg-turbo 1.4.1 was released last week, should update when possible.
Depends on: 1061240
Looks like RyanVM did the last update so I'll defer to him here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: gfx-noted
Blech, r1551 is causing trouble for us:
https://treeherder.mozilla.org/logviewer.html#?job_id=8746318&repo=try

http://sourceforge.net/p/libjpeg-turbo/code/1551/

Presumably we just need to define whatever is needed in jconfig.h, but I'm not sure the best way to do that in a platform-agnostic way.
Sorry about that.  __WORDSIZE was unfortunately not platform-agnostic, either, which is why I had to switch to using the build system to tell me whether it's doing a 64-bit or 32-bit build.  The easiest way to do that with autotools was to use its built-in type sizing mechanism, but ultimately, all you should need to do for other build systems is define SIZEOF_SIZE_T=4 for 32-bit builds and SIZEOF_SIZE_T=8 for 64-bit builds.
(Note that you instantly get about 5-10% better decompression performance on 64-bit Macs from doing this.)
I probably won't get back to this any time soon. If someone else wants to get the existing patch here building, that would be great.
Assignee: ryanvm → nobody
Status: ASSIGNED → NEW
Summary: Update libjpeg-turbo to version 1.4.1 → Update libjpeg-turbo to version 1.4.2
Blocks: 1209930
Assignee: nobody → ted
bug 1176196 - update libjpeg-turbo to 1.4.2. r?jrmuizel
Attachment #8669646 - Flags: review?(jmuizelaar)
This built fine locally and I've pushed it to try to make sure it doesn't cause any other problems. I also took the time to update the MOZCHANGES directions since libjpeg-turbo has moved to GitHub, and I also wrote a script, media/update-libjpeg.sh, to automate a bunch of the work.
Attachment #8624863 - Attachment is obsolete: true
There are a handful of unclassified oranges left on that Try push, and we need to check the Talos results, but overall it looks OK so far.
Comment on attachment 8669646 [details]
MozReview Request: bug 1176196 - update libjpeg-turbo to 1.4.2. r?jrmuizel

https://reviewboard.mozilla.org/r/21245/#review19161
Attachment #8669646 - Flags: review?(jmuizelaar) → review+
jmaher took a look at the Talos results and said everything looks good.
https://hg.mozilla.org/mozilla-central/rev/8543b8749c4e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1278648
You need to log in before you can comment on or make changes to this bug.