1176196 - Update libjpeg-turbo to version 1.4.2

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[NVD]

http://sourceforge.net/projects/libjpeg-turbo/files/1.4.1/

Libjpeg-turbo 1.4.1 was released last week, should update when possible.

Comment 1

[Benoit Girard (:BenWa)]

Looks like RyanVM did the last update so I'll defer to him here.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Update libjpeg-turbo to version 1.4.1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=809defd940e7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Blech, r1551 is causing trouble for us:
https://treeherder.mozilla.org/logviewer.html#?job_id=8746318&repo=try

http://sourceforge.net/p/libjpeg-turbo/code/1551/

Presumably we just need to define whatever is needed in jconfig.h, but I'm not sure the best way to do that in a platform-agnostic way.

Comment 4

[DRC]

Sorry about that.  __WORDSIZE was unfortunately not platform-agnostic, either, which is why I had to switch to using the build system to tell me whether it's doing a 64-bit or 32-bit build.  The easiest way to do that with autotools was to use its built-in type sizing mechanism, but ultimately, all you should need to do for other build systems is define SIZEOF_SIZE_T=4 for 32-bit builds and SIZEOF_SIZE_T=8 for 64-bit builds.

Comment 5

[DRC]

(Note that you instantly get about 5-10% better decompression performance on 64-bit Macs from doing this.)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I probably won't get back to this any time soon. If someone else wants to get the existing patch here building, that would be great.

Comment 7

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e1fa8593bbc

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1176196 - update libjpeg-turbo to 1.4.2. r?jrmuizel

bug 1176196 - update libjpeg-turbo to 1.4.2. r?jrmuizel

Comment 9

[(not currently active) Ted Mielczarek]

This built fine locally and I've pushed it to try to make sure it doesn't cause any other problems. I also took the time to update the MOZCHANGES directions since libjpeg-turbo has moved to GitHub, and I also wrote a script, media/update-libjpeg.sh, to automate a bunch of the work.

Comment 10

[(not currently active) Ted Mielczarek]

There are a handful of unclassified oranges left on that Try push, and we need to check the Talos results, but overall it looks OK so far.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8669646 [details]
MozReview Request: bug 1176196 - update libjpeg-turbo to 1.4.2. r?jrmuizel

https://reviewboard.mozilla.org/r/21245/#review19161

Comment 12

[(not currently active) Ted Mielczarek]

jmaher took a look at the Talos results and said everything looks good.

Comment 13

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8543b8749c4e20418ea17649088324e264ff4d18
bug 1176196 - update libjpeg-turbo to 1.4.2. r=jrmuizel

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8543b8749c4e