1176239 - [e10s] Tab navigation gets stuck

Status: RESOLVED FIXED

Description

[Neil Deakin]

1. Open:
  data:text/html,<input>
2. Press Tab a few times.

Expected: focus shifts from the urlbar, searchbar, document, input, then loops back to the urlbar

Actual: after focusing the document, tab navigation gets stuck and the tab key doesn't do anything

You can fix it by clicking elsewhere. It also works fine when navigating backwards with Shift+Tab.

Comment 1

[Neil Deakin]

Created attachment 8624811 [details] [diff] [review]
Work in progress patch

Comment 2

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7243bb5881e

Comment 3

[Neil Deakin]

Created attachment 8634723 [details] [diff] [review]
Cleaned up patch

Currently, when tab navigation moves to a remote <browser>, it just focuses/activates it, leaving the focus at whatever was focused last time that <browser> was active. Instead, it should redirect the tab navigation to the child process to continue looking for the next element in tab order from its starting point (or ending point if navigating backwards)

This is easier now that the F6 navigation bug is done.

Comment 4

[Neil Deakin]

Created attachment 8634725 [details] [diff] [review]
Test for this

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3876b62f498a

Comment 5

[Olli Pettay [:smaug]]

Comment on attachment 8634725 [details] [diff] [review]
Test for this

s/naviagtion/navigation/

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8634725 [details] [diff] [review]
Test for this

oh, wait, who calls add_task?

Comment 7

[Olli Pettay [:smaug]]

Comment on attachment 8634725 [details] [diff] [review]
Test for this

I guess add_task works that way. Couldn't find proper documentation though.

Comment 8

[Neil Deakin]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ea755e3cb9b7fd2f56f7f453e5ea84512972c0
changeset:  f5ea755e3cb9b7fd2f56f7f453e5ea84512972c0
user:       Neil Deakin <[e-mail]>
date:       Mon Jul 20 08:59:50 2015 -0400
description:
Bug 1176239, do tab navigation in the child when moving between the parent and child process, r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bc18893041c1703ee837120497a919d8c3d1c40a
changeset:  bc18893041c1703ee837120497a919d8c3d1c40a
user:       Neil Deakin <[e-mail]>
date:       Mon Jul 20 08:59:50 2015 -0400
description:
Bug 1176239, test e10s tab navigation between parent and child, r=smaug

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5ea755e3cb9
https://hg.mozilla.org/mozilla-central/rev/bc18893041c1

Comment 10

[Carsten Book [:Tomcat]]

Hi, sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1844736&repo=mozilla-central

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/9704aba173fd
https://hg.mozilla.org/mozilla-central/rev/d7a9e44717b7

Comment 12

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=108c54818846

Comment 13

[Neil Deakin]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7e72681dff59cb7f38dda53604a27d191a7a2e5f
changeset:  7e72681dff59cb7f38dda53604a27d191a7a2e5f
user:       Neil Deakin <[e-mail]>
date:       Thu Jul 23 10:04:15 2015 -0400
description:
Bug 1176239, do tab navigation in the child when moving between the parent and child process, r=smaug

Comment 14

[Neil Deakin]

I checked in the patch again without the test. I can't reproduce the failure but I'll keep looking.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e72681dff59