Closed
Bug 1176239
Opened 9 years ago
Closed 9 years ago
[e10s] Tab navigation gets stuck
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(2 files, 1 obsolete file)
7.81 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
3.25 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1. Open: data:text/html,<input> 2. Press Tab a few times. Expected: focus shifts from the urlbar, searchbar, document, input, then loops back to the urlbar Actual: after focusing the document, tab navigation gets stuck and the tab key doesn't do anything You can fix it by clicking elsewhere. It also works fine when navigating backwards with Shift+Tab.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Updated•9 years ago
|
tracking-e10s:
--- → +
Assignee | ||
Updated•9 years ago
|
Points: --- → 3
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7243bb5881e
Assignee | ||
Comment 3•9 years ago
|
||
Currently, when tab navigation moves to a remote <browser>, it just focuses/activates it, leaving the focus at whatever was focused last time that <browser> was active. Instead, it should redirect the tab navigation to the child process to continue looking for the next element in tab order from its starting point (or ending point if navigating backwards) This is easier now that the F6 navigation bug is done.
Attachment #8624811 -
Attachment is obsolete: true
Attachment #8634723 -
Flags: review?(bugs)
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3876b62f498a
Attachment #8634725 -
Flags: review?(bugs)
Comment 5•9 years ago
|
||
Comment on attachment 8634725 [details] [diff] [review] Test for this s/naviagtion/navigation/
Attachment #8634725 -
Flags: review?(bugs) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8634725 [details] [diff] [review] Test for this oh, wait, who calls add_task?
Attachment #8634725 -
Flags: review+ → review?(bugs)
Comment 7•9 years ago
|
||
Comment on attachment 8634725 [details] [diff] [review] Test for this I guess add_task works that way. Couldn't find proper documentation though.
Attachment #8634725 -
Flags: review?(bugs) → review+
Updated•9 years ago
|
Attachment #8634723 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 8•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ea755e3cb9b7fd2f56f7f453e5ea84512972c0 changeset: f5ea755e3cb9b7fd2f56f7f453e5ea84512972c0 user: Neil Deakin <neil@mozilla.com> date: Mon Jul 20 08:59:50 2015 -0400 description: Bug 1176239, do tab navigation in the child when moving between the parent and child process, r=smaug url: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc18893041c1703ee837120497a919d8c3d1c40a changeset: bc18893041c1703ee837120497a919d8c3d1c40a user: Neil Deakin <neil@mozilla.com> date: Mon Jul 20 08:59:50 2015 -0400 description: Bug 1176239, test e10s tab navigation between parent and child, r=smaug
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f5ea755e3cb9 https://hg.mozilla.org/mozilla-central/rev/bc18893041c1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 10•9 years ago
|
||
Hi, sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1844736&repo=mozilla-central
Status: RESOLVED → REOPENED
Flags: needinfo?(enndeakin)
Resolution: FIXED → ---
Comment 11•9 years ago
|
||
Backout: https://hg.mozilla.org/mozilla-central/rev/9704aba173fd https://hg.mozilla.org/mozilla-central/rev/d7a9e44717b7
Assignee | ||
Comment 12•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=108c54818846
Assignee | ||
Comment 13•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e72681dff59cb7f38dda53604a27d191a7a2e5f changeset: 7e72681dff59cb7f38dda53604a27d191a7a2e5f user: Neil Deakin <neil@mozilla.com> date: Thu Jul 23 10:04:15 2015 -0400 description: Bug 1176239, do tab navigation in the child when moving between the parent and child process, r=smaug
Assignee | ||
Comment 14•9 years ago
|
||
I checked in the patch again without the test. I can't reproduce the failure but I'll keep looking.
Flags: needinfo?(enndeakin)
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7e72681dff59
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•