117625 - [HAVE FIX] CTCP PING to channel floods kill the bot

Status: RESOLVED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Jacob Steenhagen]

I've noticed over the past few days that if someone join floods a channel and
starts doing a CTCP PING #channel, then the bot will blindly respond to all of
them and cause itself to get kicked for an flooding.

Comment 1

[Jacob Steenhagen]

Attachment: Ignore CTCP PING to channel

This cause oopsbot to ignore any CTCP PING that's sent to the channel.	The bot
is still vulerable to being ping flooded directly, but this should eliminate
the most common senario.

Comment 2

[Hixie (not reading bugmail)]

Attachment: Patch: make CTCP Pings handlable by modules

Comment 3

[Hixie (not reading bugmail)]

Attachment: Patch: same patch, but with additional changes for bug 111831

Comment 4

[timeless]

afaik ctcp support isn't scalable. but this is a flood patch, so ...

Comment 5

[Hixie (not reading bugmail)]

How do you mean, not scalable?

Comment 6

[Hixie (not reading bugmail)]

Attachment: Updated Patch 1.2

I moved CTCP Version handling into mozbot.pl as well.

Comment 7

[Jacob Steenhagen]

Comment on attachment 68123 [details] [diff] [review]
Updated Patch 1.2

OK, this seems to work.  I am worried that the implimentation in bug 72943 will
lead to a DOS attack being possible, but that's another issue :)

r=jake

Comment 8

[Hixie (not reading bugmail)]

checked in