1176276 - [Raptor] Reboot test intermittently does not pick up adb connection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30674

When running the reboot test, sometimes adb completely dies on its connection to the device. I did notice that in the Settings of the device that Developer settings does not have it set for "ADB only" or "ADB and DevTools". I'm going to set DEVICE_DEBUG=1 for `make raptor` in order to ensure ADB stays set.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30674

Comment 2

[Robert Wood [:rwood]]

(In reply to :Eli Perelman from comment #1)
> Created attachment 8624777 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30674

I wonder if turning on DEVICE_DEBUG will slow down the device or adversely effect the perf numbers...

Comment 3

[:Eli Perelman]

I looked into some of the prefs that DEVICE_DEBUG sets and none of them seem like they would have much of an effect. Still probably wouldn't hurt to do a perf comparison though. I'll procure one.

Comment 4

[Robert Wood [:rwood]]

Comment on attachment 8624777 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30674

LGTM and make raptor works fine

Comment 5

[:Eli Perelman]

Running this locally against master, as well as inspecting the "hidden" jobs on Taskcluster, it appears the performance difference is negligible. Thanks Rob!

Comment 6

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/gaia/commit/cd570fb72e7e6a2dcf004106e18d580c2e129b7c