1176388 - Add pref to disable the border around loading images

Status: NEW

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like a crappy MOTIF app, and most other browsers seem to just draw nothing at all. In conjunction with the pref in bug 1176081 toggled, we would also draw nothing.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add a pref to disble drawing the loading image borders

This builds upon the patch in bug 1176081

Comment 2

[Seth Fowler [:seth] [:s2h]]

This is fine, but do we really need *another* pref? If this is the version we want to ship, why don't we just make browser.display.show_loading_image_placeholder behave this way?

Comment 3

[Timothy Nikkel (:tnikkel)]

I thought Chrome drew a border in this situation, less pronounced then what we do though.

I think I kind of like the border actually, gives an indication that something goes there with out being too eye catching. We could stand to tone down our border though.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

You can use http://www.deelay.me/ to see how things look today. Chrome doesn't draw anything here for me (both desktop and android), but maybe it's because there is no explicit size?

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Anthony, what do you think about image borders while loading?

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I agree, we shouldn't draw anything at all unless there's a compelling reason to. It doesn't really _feel_ great when I see those placeholders.

I don't think this needs to be a pref under Settings. Let's not have that placeholder image while things are loading.

Comment 7

[Seth Fowler [:seth] [:s2h]]

Personally I don't like the borders either. I'm perfectly happy with displaying nothing until the image loads.

So snorp, what's the conclusion? Are you going to update the patch to just use the |browser.display.show_loading_image_placeholder| pref? Or do you think it's worth supporting 3 different behaviors here?

Comment 8

[Timothy Nikkel (:tnikkel)]

I talked to snorp a few days ago, we concluded that I would incorporate this patch into mine in bug 1176081. I think I'll just have one pref, so that it can be disabled late in the game without code modifications if we need.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Thanks tn

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.