1176422 - AutocompleteResults.get_matching_text can return non-matching text for results not of type bookmark

Status: RESOLVED INACTIVE

(Testing :: Firefox UI Tests, defect)

Description

[Barbara Miller (:galgeek)]

AutocompleteResults.get_matching_text method returns unmatched text when checking autocomplete results of a result type other than 'bookmark'.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Barbara, can you please give us an example here? It would make it easier to understand the problem. Right now I have difficulties with it. Thanks.

Comment 2

[Barbara Miller (:galgeek)]

When test_toolbars.py checks, in test_matching_text, all autocomplete results, not just those of type "bookmark", it errors with this traceback:

 0:04.47 TEST_START: MainThread test_toolbars.py TestAutoCompleteResults.test_matching_text
 0:05.34 TEST_END: MainThread FAIL, expected PASS
Traceback (most recent call last):
  File "/Users/bara/.virtualenvs/ffuit/lib/python2.7/site-packages/marionette_client-0.12-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/Users/bara/Dev/ffuit/firefox_ui_harness/decorators.py", line 23, in wrapper
    return target(self, *args, **kwargs)
  File "/Users/bara/Dev/ffuit/firefox_puppeteer/tests/test_toolbars.py", line 143, in test_matching_text
    self.assertIn(match_fragment.lower(), input_text)
AssertionError: u'- search with yahoo' not found in 'moz'

I'm not sure that I understand what's happening in the get_matching_text method, or I'd try to suggest a fix.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ah, I see. Then we need a fix similar to bug 1174661.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the removal of the firefox-puppeteer package this API doesn't exist anymore.