1176439 - Persistent "Restart Nightly to Update" when I'm already on latest Nightly. Service needs improvement to avoid missing registry key for install location

Status: NEW

(Toolkit :: Application Update, defect, P3)

Description

[Vladan Djeric (:vladan)]

Attachment: Screenshot 2015-06-19 19.37.59.png

This behaviour is reproducible on this profile. It might be a symptom of a worse issue. 

Which updater logs should I attach?

I'm on Windows 7 64-bit, 32-bit Nightly from June 19th, no extensions, logged in as a user with admin privileges.

Comment 1

[Vladan Djeric (:vladan)]

I should mention that restarting doesn't clear that button

Comment 2

[Robert Strong (they/them - no direct email)]

In about:config change the app.update.log pref to true and the devtools.errorconsole.enabled pref to true. Open the about error console under tools -> web developer and click clear. Open the about window and check the error console for messages that start with aus. Paste these message into a file and attach it to this bug.

Comment 3

[Robert Strong (they/them - no direct email)]

For comment #2

Comment 4

[Vladan Djeric (:vladan)]

Attachment: error_console.txt

The update.status file referenced in the error console has contents "succeeded", the chrome.manifest file is not at the indicated path, it's actually in c:\Program Files (x86)\nightly2\browser\chrome.manifest

Comment 5

[Vladan Djeric (:vladan)]

Attachment: error_console2.txt

Additional messages were posted to the error console a few minutes after I attached error_console.txt

Comment 6

[Robert Strong (they/them - no direct email)]

I noticed the install directory is Nightly2. Did you renamed the install directory recently?

Comment 7

[Robert Strong (they/them - no direct email)]

Also, is this by chance an install from a zip build?

Comment 8

[Vladan Djeric (:vladan)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> I noticed the install directory is Nightly2. Did you renamed the install
> directory recently?

No, I needed two installations of Nightly at one point, so I installed Nightly a second time in Nightly2 (a long time ago)

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #7)
> Also, is this by chance an install from a zip build?

Nope, I installed it using a Nightly installer a long time ago.

Comment 9

[Robert Strong (they/them - no direct email)]

Is the other install of Nightly have working updates?

Comment 10

[Vladan Djeric (:vladan)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> Is the other install of Nightly have working updates?

I think I know what's going on now. The nightlies in Nightly1 and Nightly2 directories were both running. Nightly1 was out-of-date and Nightly2 was up-to-date. The Help->About dialog in Nightly2 was indicating that it needed to be restarted even though it was up to date, because Nightly1 was out of date.

Once I updated Nightly1 and restarted it, Nightly2 no longer displayed the incorrect "Restart to update" message and instead showed "Nightly is being updated by another instance".

Comment 11

[Robert Strong (they/them - no direct email)]

Could you attach the registry entries under
HKCU\Software\Mozilla\Firefox\TaskBarIDs\
and
HKLM\Software\Mozilla\Firefox\TaskBarIDs\

Comment 12

[Vladan Djeric (:vladan)]

Attachment: HKCUSoftwareMozillaFirefoxTaskBarIDs.txt

You'll notice I've had a LOT of different Firefox versions installed, this is my development & testing machine :)

Comment 13

[Vladan Djeric (:vladan)]

Attachment: HKLMSoftwareMozillaFirefoxTaskBarIDs.txt

Comment 14

[Robert Strong (they/them - no direct email)]

The registry key for this install location used by the service is missing. When time permits I'll look into making that code more robust.