1176446 - TextureClientD3D11 should take into account the layer backend when allocating a surface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1155828#c39

Essentially, the TextureClient can create a d3d 11 surface. Whenever a caller calls BorrowDrawTarget(), it will get a d3d 11 draw target even if the backend is d2d 1.0. This can create large performance penalties on nvidia GPUs. The TextureClient should allocate a surface based on the backend as well so it meshes well with DrawTargets created by CreateOffscreenContentDrawTarget.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Only alloc d3d11 device texture if we have a d3d11 backend

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8624988 [details] [diff] [review]
Only alloc d3d11 device texture if we have a d3d11 backend

Review of attachment 8624988 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d11/TextureD3D11.cpp
@@ +453,2 @@
>  
> +  if (gfxPrefs::Direct2DUse1_1() && d3d11device && haveD3d11Backend) {

I think we can skip the gfxPrefs check here (BackendType::DIRECT2D1_1 is only added to the 'allowed' list if this pref is true), and just assert that d3d11device is != nullptr if haveD3D11Backend is true.

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8624988 [details] [diff] [review]
Only alloc d3d11 device texture if we have a d3d11 backend

Review of attachment 8624988 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d11/TextureD3D11.cpp
@@ +453,2 @@
>  
> +  if (gfxPrefs::Direct2DUse1_1() && d3d11device && haveD3d11Backend) {

I believe what Matt said is correct.

Comment 4

[Mason Chang [Inactive] [:mchang]]

Attachment: Only alloc d3d11 device texture if we have a d3d11 backend

Carrying r+, updated with Matt's feedback from comment 2.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bec656738ba3

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7085b1090e92

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7085b1090e92